Issue 14949004: ash: Rename tray_views.{h,cc} to tray_utils.{h,cc}

Issue 14949004: ash: Rename tray_views.{h,cc} to tray_utils.{h,cc} (Closed)

Created:
7 years, 7 months ago by tfarina

Modified:
7 years, 7 months ago

Reviewers:
xiyuan, James Cook

CC:
chromium-reviews, sadrul, ben+watch_chromium.org, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ash: Rename tray_views.{h,cc} to tray_utils.{h,cc} BUG=174228 R=jamescook@chromium.org TBR=xiyuan@chromium.org # for trivial change in chrome/browser/chromeos/system/ Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198445

Patch Set 2 : fix browsertest #

Total comments: 1

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -122 lines)			Patch
M	ash/ash.gyp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	ash/system/brightness/tray_brightness.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	ash/system/chromeos/label_tray_view.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	ash/system/chromeos/network/tray_network.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ash/system/chromeos/tray_display.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	ash/system/date/date_view.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ash/system/ime/tray_ime.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ash/system/locale/tray_locale.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	ash/system/monitor/tray_monitor.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	ash/system/power/power_status_view.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	ash/system/power/tray_power.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ash/system/session_length_limit/tray_session_length_limit.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ash/system/tray/hover_highlight_view.cc	View		1 chunk	+0 lines, -1 line	1 comment	Download
M	ash/system/tray/system_tray.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	ash/system/tray/tray_image_item.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ash/system/tray/tray_item_more.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
A +	ash/system/tray/tray_utils.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
A +	ash/system/tray/tray_utils.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
D	ash/system/tray/tray_views.h	View		1 chunk	+0 lines, -35 lines	0 comments	Download
D	ash/system/tray/tray_views.cc	View		1 chunk	+0 lines, -65 lines	0 comments	Download
M	ash/system/tray_update.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	ash/system/user/tray_user.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ash/system/web_notification/web_notification_tray.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/system/tray_accessibility_browsertest.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

James Cook

LGTM https://codereview.chromium.org/14949004/diff/5002/ash/system/tray/hover_highlight_view.cc File ash/system/tray/hover_highlight_view.cc (left): https://codereview.chromium.org/14949004/diff/5002/ash/system/tray/hover_highlight_view.cc#oldcode9 ash/system/tray/hover_highlight_view.cc:9: #include "ash/system/tray/tray_views.h" It's great that you found all ...

7 years, 7 months ago (2013-05-05 22:20:45 UTC) #2

tfarina

TBRing Xiyuan for trivial change in chrome/browser/chromeos/system/.

7 years, 7 months ago (2013-05-05 22:44:34 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/14949004/5002

7 years, 7 months ago (2013-05-05 22:44:43 UTC) #4

Message was sent while issue was closed.

Change committed as 198445

Expand Messages | Collapse Messages