Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: tools/gn/target.h

Issue 1494883002: GN: Makes GN output deterministic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Moves sort into ninja_toolchain_writer.cc for consistency Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/target.h
diff --git a/tools/gn/target.h b/tools/gn/target.h
index 10d3b05dd992ed1be07bb2a0a02248f4205b9793..96678091fcc9af18bd8d2eb153e2c2c9b19f2efb 100644
--- a/tools/gn/target.h
+++ b/tools/gn/target.h
@@ -14,6 +14,7 @@
#include "base/macros.h"
#include "tools/gn/action_values.h"
#include "tools/gn/config_values.h"
+#include "tools/gn/dereference_comparator.h"
#include "tools/gn/inherited_libraries.h"
#include "tools/gn/item.h"
#include "tools/gn/label_ptr.h"
@@ -199,7 +200,7 @@ class Target : public Item {
const OrderedSet<SourceDir>& all_lib_dirs() const { return all_lib_dirs_; }
const OrderedSet<std::string>& all_libs() const { return all_libs_; }
- const std::set<const Target*>& recursive_hard_deps() const {
+ const PointerSet<const Target>& recursive_hard_deps() const {
return recursive_hard_deps_;
}
@@ -244,6 +245,8 @@ class Target : public Item {
return dependency_output_file_;
}
+ bool operator<(const Target& other) const;
+
private:
FRIEND_TEST_ALL_PREFIXES(Target, ResolvePrecompiledHeaders);
@@ -306,7 +309,7 @@ class Target : public Item {
// All hard deps from this target and all dependencies. Filled in when this
// target is marked resolved. This will not include the current target.
- std::set<const Target*> recursive_hard_deps_;
+ PointerSet<const Target> recursive_hard_deps_;
// Used for all binary targets. The precompiled header values in this struct
// will be resolved to the ones to use for this target, if precompiled

Powered by Google App Engine
This is Rietveld 408576698