tools/gn/commands.cc - Issue 1494883002: GN: Makes GN output deterministic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/commands.cc

Issue 1494883002: GN: Makes GN output deterministic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Moves sort into ninja_toolchain_writer.cc for consistency Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/commands.cc

diff --git a/tools/gn/commands.cc b/tools/gn/commands.cc

index ed7a009d6af2c6f7a866d7d82e753b701d07760e..2087136cb0fe4138656d564493ce394924251209 100644

--- a/tools/gn/commands.cc

+++ b/tools/gn/commands.cc

@@ -6,6 +6,7 @@

#include "base/command_line.h"

#include "tools/gn/builder.h"

+#include "tools/gn/dereference_comparator.h"

#include "tools/gn/filesystem_utils.h"

#include "tools/gn/item.h"

#include "tools/gn/label.h"

@@ -494,7 +495,7 @@ void FilterAndPrintTargets(bool indent, std::vector<const Target*>* targets) {

}

void FilterAndPrintTargetSet(bool indent,

- const std::set<const Target*>& targets) {

+ const PointerSet<const Target>& targets) {

std::vector<const Target*> target_vector(targets.begin(), targets.end());

FilterAndPrintTargets(indent, &target_vector);

}