tools/gn/command_refs.cc - Issue 1494883002: GN: Makes GN output deterministic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/command_refs.cc

Issue 1494883002: GN: Makes GN output deterministic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Moves sort into ninja_toolchain_writer.cc for consistency Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/command_refs.cc

diff --git a/tools/gn/command_refs.cc b/tools/gn/command_refs.cc

index 742b43b350338652429fdd0fad767718ed6fb877..03ee420028bda82516e2c0eac47595646721e8ed 100644

--- a/tools/gn/command_refs.cc

+++ b/tools/gn/command_refs.cc

@@ -10,6 +10,7 @@

#include "base/strings/string_split.h"

#include "tools/gn/commands.h"

#include "tools/gn/deps_iterator.h"

+#include "tools/gn/dereference_comparator.h"

#include "tools/gn/filesystem_utils.h"

#include "tools/gn/input_file.h"

#include "tools/gn/item.h"

@@ -21,7 +22,7 @@ namespace commands {

namespace {

-typedef std::set<const Target*> TargetSet;

+typedef PointerSet<const Target> TargetSet;

typedef std::vector<const Target*> TargetVector;

// Maps targets to the list of targets that depend on them.