tools/gn/ninja_toolchain_writer.h - Issue 1494883002: GN: Makes GN output deterministic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/ninja_toolchain_writer.h

Issue 1494883002: GN: Makes GN output deterministic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Tweaked some comments for clarity Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/ninja_toolchain_writer.h

diff --git a/tools/gn/ninja_toolchain_writer.h b/tools/gn/ninja_toolchain_writer.h

index 50cb7ef60db5f1e6951eceacb0e05c209c776ce6..00a6bf1914954e9cbff88f8c2c6566c692a8c75c 100644

--- a/tools/gn/ninja_toolchain_writer.h

+++ b/tools/gn/ninja_toolchain_writer.h

@@ -26,7 +26,7 @@ class NinjaToolchainWriter {

// associated with the toolchain.

static bool RunAndWriteFile(const Settings* settings,

const Toolchain* toolchain,

- const std::vector<const Target*>& targets);

+ std::vector<const Target*>& targets);

private:

FRIEND_TEST_ALL_PREFIXES(NinjaToolchainWriter, WriteToolRule);