Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/a64/code-stubs-a64.cc

Issue 149483002: A64: Handle Smi representation in MathAbs and fix MathPowStub (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/a64
Patch Set: Do not smi-untag integer32 exponents in MathPower Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/a64/lithium-a64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2198 matching lines...) Expand 10 before | Expand all | Expand 10 after
2209 2209
2210 { 2210 {
2211 AllowExternalCallThatCantCauseGC scope(masm); 2211 AllowExternalCallThatCantCauseGC scope(masm);
2212 __ Mov(saved_lr, lr); 2212 __ Mov(saved_lr, lr);
2213 __ CallCFunction( 2213 __ CallCFunction(
2214 ExternalReference::power_double_double_function(masm->isolate()), 2214 ExternalReference::power_double_double_function(masm->isolate()),
2215 0, 2); 2215 0, 2);
2216 __ Mov(lr, saved_lr); 2216 __ Mov(lr, saved_lr);
2217 __ B(&done); 2217 __ B(&done);
2218 } 2218 }
2219
2220 // Handle SMI exponents.
2221 __ Bind(&exponent_is_smi);
2222 // x10 base_tagged The tagged base (input).
2223 // x11 exponent_tagged The tagged exponent (input).
2224 // d1 base_double The base as a double.
2225 __ SmiUntag(exponent_integer, exponent_tagged);
2219 } 2226 }
2220 2227
2221 // Handle integer (and SMI) exponents.
2222 __ Bind(&exponent_is_smi);
2223 // x10 base_tagged The tagged base (input).
2224 // x11 exponent_tagged The tagged exponent (input).
2225 // d1 base_double The base as a double.
2226 __ SmiUntag(exponent_integer, exponent_tagged);
2227 __ Bind(&exponent_is_integer); 2228 __ Bind(&exponent_is_integer);
2228 // x10 base_tagged The tagged base (input). 2229 // x10 base_tagged The tagged base (input).
2229 // x11 exponent_tagged The tagged exponent (input). 2230 // x11 exponent_tagged The tagged exponent (input).
2230 // x12 exponent_integer The exponent as an integer. 2231 // x12 exponent_integer The exponent as an integer.
2231 // d1 base_double The base as a double. 2232 // d1 base_double The base as a double.
2232 2233
2233 // Find abs(exponent). For negative exponents, we can find the inverse later. 2234 // Find abs(exponent). For negative exponents, we can find the inverse later.
2234 Register exponent_abs = x13; 2235 Register exponent_abs = x13;
2235 __ Cmp(exponent_integer, 0); 2236 __ Cmp(exponent_integer, 0);
2236 __ Cneg(exponent_abs, exponent_integer, mi); 2237 __ Cneg(exponent_abs, exponent_integer, mi);
(...skipping 4843 matching lines...) Expand 10 before | Expand all | Expand 10 after
7080 __ Bind(&fast_elements_case); 7081 __ Bind(&fast_elements_case);
7081 GenerateCase(masm, FAST_ELEMENTS); 7082 GenerateCase(masm, FAST_ELEMENTS);
7082 } 7083 }
7083 7084
7084 7085
7085 #undef __ 7086 #undef __
7086 7087
7087 } } // namespace v8::internal 7088 } } // namespace v8::internal
7088 7089
7089 #endif // V8_TARGET_ARCH_A64 7090 #endif // V8_TARGET_ARCH_A64
OLDNEW
« no previous file with comments | « no previous file | src/a64/lithium-a64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698