Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(883)

Issue 149483002: A64: Handle Smi representation in MathAbs and fix MathPowStub (Closed)

Created:
6 years, 10 months ago by ulan
Modified:
6 years, 10 months ago
CC:
v8-dev
Visibility:
Public.

Description

A64: Handle Smi representation in MathAbs and fix MathPowStub. TEST=mozilla/ecma/Expressions/11.7.1 R=baptiste.afsa@arm.com, jochen@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18911

Patch Set 1 #

Patch Set 2 : Do not smi-untag integer32 exponents in MathPower #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M src/a64/code-stubs-a64.cc View 1 1 chunk +7 lines, -6 lines 0 comments Download
M src/a64/lithium-a64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/a64/lithium-codegen-a64.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
lgtm
6 years, 10 months ago (2014-01-29 10:38:31 UTC) #1
ulan
PTAL, this fixes mozilla/js1_5/Regress/regress-80981 Jochen, I uploaded a new patch with a fix for MathPower.
6 years, 10 months ago (2014-01-29 13:59:15 UTC) #2
baptiste.afsa1
lgtm
6 years, 10 months ago (2014-01-29 14:15:16 UTC) #3
ulan
6 years, 10 months ago (2014-01-29 14:33:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r18911 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698