Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 1494803005: GAE Datastore - Fix derived types not being reflected properly (Closed)

Created:
5 years ago by hinoka
Modified:
5 years ago
Reviewers:
dnj, Vadim Sh., iannucci
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Base URL:
https://github.com/luci/gae.git@master
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

GAE Datastore - Fix derived meta types not being reflected properly Stuff like "type FooBar string" were not allowed as metadata fields correctly. BUG= Committed: https://github.com/luci/gae/commit/b362e06075dc533cdcfc2b7f0a91cbbc8e66c360

Patch Set 1 #

Patch Set 2 : Tests #

Patch Set 3 : Remove debug prints #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -8 lines) Patch
M service/datastore/pls_impl.go View 1 2 3 chunks +13 lines, -8 lines 0 comments Download
M service/datastore/pls_test.go View 1 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
hinoka
5 years ago (2015-12-04 02:30:00 UTC) #4
hinoka
Remove debug prints
5 years ago (2015-12-04 02:31:39 UTC) #6
iannucci
lgtm
5 years ago (2015-12-04 02:39:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1494803005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1494803005/40001
5 years ago (2015-12-04 02:39:38 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Luci-GAE Presubmit on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Luci-GAE%20Presubmit/builds/48)
5 years ago (2015-12-04 02:46:20 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1494803005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1494803005/40001
5 years ago (2015-12-04 02:51:28 UTC) #14
commit-bot: I haz the power
5 years ago (2015-12-04 02:55:15 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://github.com/luci/gae/commit/b362e06075dc533cdcfc2b7f0a91cbbc8e66c360

Powered by Google App Engine
This is Rietveld 408576698