Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 1494803003: bindings: Improves the speed perf of EventTarget.dispatchEvent. (Closed)

Created:
5 years ago by Yuki
Modified:
5 years ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bindings: Improves the speed perf of EventTarget.dispatchEvent. Introduces a hack to recover the speed performance of EventTarget.dispatchEvent. The code looks like close to the one before http://crrev.com/1417023006 . BUG=564407, 509936 Committed: https://crrev.com/6974d3335769e3e2a43d6bb24506a40ab98b2066 Cr-Commit-Position: refs/heads/master@{#362937}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M third_party/WebKit/Source/bindings/templates/methods.cpp View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Yuki
Could you review this CL?
5 years ago (2015-12-03 07:48:42 UTC) #2
haraken
LGTM
5 years ago (2015-12-03 07:54:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1494803003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1494803003/1
5 years ago (2015-12-03 07:55:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 09:08:39 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-03 09:10:26 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6974d3335769e3e2a43d6bb24506a40ab98b2066
Cr-Commit-Position: refs/heads/master@{#362937}

Powered by Google App Engine
This is Rietveld 408576698