[Android] Auto-generate v14 style xml resources from the exisitng v17 style resources.

build/android/gyp/generate_v14_resources.py

 #!/usr/bin/env python
 #
 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Convert Android xml resources to API 14 compatible.
 
 There are two reasons that we cannot just use API attributes,
 so we are generating another set of resources by this script.
@@ skipping 45 matching lines @@
 def IterateXmlElements(node):
   """minidom helper function that iterates all the element nodes.
   Iteration order is pre-order depth-first."""
   if node.nodeType == node.ELEMENT_NODE:
     yield node
   for child_node in node.childNodes:
     for child_node_element in IterateXmlElements(child_node):
       yield child_node_element
 
 
-def GenerateV14Resource(input_filename, output_filename):
-  """Convert resource to API 14 compatible resource.
+def GenerateV14StyleResource(dom, output_file):
+  """Convert style resource to API 14 compatible style resource.
+
+  It's mostly a simple replacement, s/Start/Left s/End/Right,
+  on the attribute names specified by <item> element.
+  """
+  for style_element in dom.getElementsByTagName('style'):
+    for item_element in style_element.getElementsByTagName('item'):
+      namespace, name = item_element.attributes['name'].value.split(':')
+      # Note: namespace == 'android' is not precise because

[newt (away), 2013/05/06 20:55:55]

agreed, checking for "android" is plenty. if we start aliasing "android" to some
other namespace in our xml files, we'll have a lot more problems than just this
to deal with.

+      # we are looking for 'http://schemas.android.com/apk/res/android' and
+      # 'android' can be aliased to another name in layout xml files where
+      # this style is used. e.g. xmlns:android="http://crbug.com/".
+      if namespace == 'android' and name in ATTRIBUTES_TO_MAP:
+        mapped_name = ATTRIBUTES_TO_MAP[name]
+        item_element.attributes['name'] = namespace + ':' + mapped_name
+
+  build_utils.MakeDirectory(os.path.dirname(output_file))
+  with open(output_file, 'w') as f:
+    dom.writexml(f, '', '  ', '\n', encoding='utf-8')
+
+
+def GenerateV14LayoutResource(dom, output_file):
+  """Convert layout resource to API 14 compatible layout resource.
 
   It's mostly a simple replacement, s/Start/Left s/End/Right,
   on the attribute names.
   """
-  dom = minidom.parse(input_filename)
-
   for element in IterateXmlElements(dom):
     all_names = element.attributes.keysNS()
 
     # Iterate all the attributes to find attributes to convert.
     # Note that name variable is actually a tuple that has namespace and name.
     # For example,
     # name == ('http://schemas.android.com/apk/res/android', 'paddingStart')
     for name, value in list(element.attributes.itemsNS()):
       # Note: gravity attributes are not necessary to convert because
       # start/end values are backward-compatible. Explained at
@@ skipping 12 matching lines @@
         # setAttributeNS. Hence this workaround.
         # This is a similar bug discussion about minidom namespace normalizing.
         # http://stackoverflow.com/questions/863774/how-to-generate-xml-documents-with-namespaces-in-python
         element.setAttribute('android:' + mapped_name[1], value)
         del element.attributes[name]
       elif name in ATTRIBUTES_TO_MAP_NS_VALUES:
         # TODO(kkimlabs): Enable  warning once layouts have been converted
         # print >> sys.stderror, 'Warning: layout should use xxx instead of yyy'
         pass
 
-  build_utils.MakeDirectory(os.path.dirname(output_filename))
-  with open(output_filename, 'w') as f:
-    dom.writexml(f, '  ', '\n', encoding='utf-8')
+  build_utils.MakeDirectory(os.path.dirname(output_file))
+  with open(output_file, 'w') as f:
+    dom.writexml(f, '', '  ', '\n', encoding='utf-8')
 
 
-def GenerateV14ResourcesInDir(input_dir, output_dir):
+def GenerateV14XmlResourcesInDir(input_dir, output_dir):
   """Convert resources to API 14 compatible XML resources in the directory."""
   for input_file in build_utils.FindInDirectory(input_dir, '*.xml'):
-    output_path = os.path.join(output_dir,
+    output_file = os.path.join(output_dir,
                                os.path.relpath(input_file, input_dir))
-    GenerateV14Resource(input_file, output_path)
+    dom = minidom.parse(input_file)
+    root_element = IterateXmlElements(dom).next()
+    if root_element.nodeName == 'resources':
+      if root_element.getElementsByTagName('style'):
+        GenerateV14StyleResource(dom, output_file)
+    else:
+      GenerateV14LayoutResource(dom, output_file)
 
 
 def ParseArgs():
   """Parses command line options.
 
   Returns:
     An options object as from optparse.OptionsParser.parse_args()
   """
   parser = optparse.OptionParser()
   parser.add_option('--res-dir',
@@ skipping 22 matching lines @@
   build_utils.MakeDirectory(options.res_v14_dir)
 
   for name in os.listdir(options.res_dir):
     if not os.path.isdir(os.path.join(options.res_dir, name)):
       continue
 
     dir_pieces = name.split('-')
     resource_type = dir_pieces[0]
     qualifiers = dir_pieces[1:]
 
-    # We only convert resources under layout*/ and xml*/.
-    if resource_type not in ('layout', 'xml'):
-      continue
-
     # Android pre-v17 API doesn't support RTL. Skip.
     if 'ldrtl' in qualifiers:
       continue
 
-    # Convert all the resource files.
-    input_path = os.path.join(options.res_dir, name)
-    output_path = os.path.join(options.res_v14_dir, name)
-    GenerateV14ResourcesInDir(input_path, output_path)
+    input_dir = os.path.join(options.res_dir, name)
+    output_dir = os.path.join(options.res_v14_dir, name)
+
+    # We only convert resources under layout*/, xml*/,
+    # and style resources under values*/.
+    if resource_type in ('layout', 'xml', 'values'):

[newt (away), 2013/05/06 20:55:55]

we know that style resources live in "values", and layouts live in "layout" or
"xml". I think you should differentiate here, i.e. only call
GenerateV14StyleResource() for resources in values, and vice versa. (like you do
in copy_v17_resources.py)

Also, I'm not sure why we have any layouts living in the res/xml folder. I
believe those should be removed, though that can be a later change.

[Kibeom Kim (inactive), 2013/05/06 22:28:01]

Done.

+      GenerateV14XmlResourcesInDir(input_dir, output_dir)
 
   if options.stamp:
     build_utils.Touch(options.stamp)
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv))