Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1494783002: [Net Internals Page] Fix Element Shrinkage from Pinch-to-Zoom. (Closed)

Created:
5 years ago by huangs
Modified:
5 years ago
Reviewers:
mmenke
CC:
chromium-reviews, eroman, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Net Internals Page] Fix Element Shrinkage from Pinch-to-Zoom Under pinch-to-zoom, there's no extra redraw event. However, the old WindowView.resetGeometry() code was sensitive to dimensions (window.innerWidth/innerHeight) that change with pinch-to-zoom. So when page is pinch-to-zoomed in, refreshing or resizing triggers redraw, causing inconsistent element sizing. Our fix is to use dimensions that are insensitive to pinch-to-zoom, i.e., document.documentElement.clientWidth/clientHeight. Under 100% pinch-to-zoom, these are identical to the old dimensions except when scroll bars are present. BUG=481842 Committed: https://crrev.com/627ef0697394af88d734f40ab437b2d353f427be Cr-Commit-Position: refs/heads/master@{#363007}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/resources/net_internals/view.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
huangs
PTAL.
5 years ago (2015-12-02 22:50:32 UTC) #2
mmenke
On 2015/12/02 22:50:32, huangs wrote: > PTAL. LGTM
5 years ago (2015-12-02 23:10:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1494783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1494783002/1
5 years ago (2015-12-03 16:12:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 18:08:39 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-03 18:09:32 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/627ef0697394af88d734f40ab437b2d353f427be
Cr-Commit-Position: refs/heads/master@{#363007}

Powered by Google App Engine
This is Rietveld 408576698