Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: src/IceBrowserCompileServer.h

Issue 1494753003: cleanup main (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: changes suggested by stichnot Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/IceBuildDefs.h » ('j') | src/IceBuildDefs.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceBrowserCompileServer.h
diff --git a/src/IceBrowserCompileServer.h b/src/IceBrowserCompileServer.h
index ce3f60de12dd83cefcebd45a861699d19e101179..48c7cbb617fefb026b0a15adf7eedefd8bdaffdc 100644
--- a/src/IceBrowserCompileServer.h
+++ b/src/IceBrowserCompileServer.h
@@ -37,14 +37,13 @@ namespace Ice {
/// defaults that make sense in the browser case. The output file is specified
/// via a posix FD, and input bytes are pushed to the server.
class BrowserCompileServer : public CompileServer {
- BrowserCompileServer() = delete;
BrowserCompileServer(const BrowserCompileServer &) = delete;
BrowserCompileServer &operator=(const BrowserCompileServer &) = delete;
class StringStream;
public:
- explicit BrowserCompileServer(Compiler &Comp)
- : CompileServer(Comp), InputStream(nullptr), HadError(false) {}
+ explicit BrowserCompileServer()
Jim Stichnoth 2015/12/07 17:37:13 Remove "explicit" for a zero-arg ctor.
rkotlerimgtec 2015/12/07 18:32:07 Done.
+ : InputStream(nullptr), HadError(false) {}
Jim Stichnoth 2015/12/07 17:37:12 You can omit InputStream(nullptr) because of the "
rkotlerimgtec 2015/12/07 18:32:07 Done.
~BrowserCompileServer() final;
« no previous file with comments | « no previous file | src/IceBuildDefs.h » ('j') | src/IceBuildDefs.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698