cleanup main

src/IceBrowserCompileServer.h

 //===- subzero/src/IceBrowserCompileServer.h - Browser server ---*- C++ -*-===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 ///
 /// \file
@@ skipping 19 matching lines @@
 } // end of namespace llvm
 
 namespace Ice {
 
 /// The browser variant of the compile server. Compared to the commandline
 /// version, this version gets compile requests over IPC. Each compile request
 /// will have a slimmed down version of argc, argv while other flags are set to
 /// defaults that make sense in the browser case. The output file is specified
 /// via a posix FD, and input bytes are pushed to the server.
 class BrowserCompileServer : public CompileServer {
-  BrowserCompileServer() = delete;
   BrowserCompileServer(const BrowserCompileServer &) = delete;
   BrowserCompileServer &operator=(const BrowserCompileServer &) = delete;
   class StringStream;
 
 public:
-  explicit BrowserCompileServer(Compiler &Comp)
-      : CompileServer(Comp), InputStream(nullptr), HadError(false) {}
+  explicit BrowserCompileServer()

[Jim Stichnoth, 2015/12/07 17:37:13]

Remove "explicit" for a zero-arg ctor.

[rkotlerimgtec, 2015/12/07 18:32:07]

Done.

+      : InputStream(nullptr), HadError(false) {}

[Jim Stichnoth, 2015/12/07 17:37:12]

You can omit InputStream(nullptr) because of the "= nullptr" specification in
the declaration below.

[rkotlerimgtec, 2015/12/07 18:32:07]

Done.

 
   ~BrowserCompileServer() final;
 
   void run() final;
 
   ErrorCode &getErrorCode() final;
 
   /// Parse and set up the flags for compile jobs.
   void getParsedFlags(uint32_t NumThreads, int argc, char **argv);
 
@@ skipping 48 matching lines @@
   std::unique_ptr<ELFStreamer> ELFStream;
   ClFlags Flags;
   ClFlagsExtra ExtraFlags;
   std::thread CompileThread;
   std::atomic<bool> HadError;
 };
 
 } // end of namespace Ice
 
 #endif // SUBZERO_SRC_ICEBROWSERCOMPILESERVER_H