Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4893)

Unified Diff: chrome/browser/ui/views/download/download_item_view.cc

Issue 14947007: [Downloads] Allow acquiring dangerous download file. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rename methods for consistency Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/download/download_item_view.cc
diff --git a/chrome/browser/ui/views/download/download_item_view.cc b/chrome/browser/ui/views/download/download_item_view.cc
index bf8787ebf2ecb5cb7954c887e7bdb5d1c475df1c..97afe48c7766ab896ad5381df577a326466ecdf2 100644
--- a/chrome/browser/ui/views/download/download_item_view.cc
+++ b/chrome/browser/ui/views/download/download_item_view.cc
@@ -526,7 +526,9 @@ void DownloadItemView::ButtonPressed(
base::Time::Now() - creation_time_);
if (download()->IsPartialDownload())
download()->Cancel(true);
- download()->Delete(DownloadItem::DELETE_DUE_TO_USER_DISCARD);
+ download()->DiscardDangerousDownload(
+ DownloadItem::DELETE_DUE_TO_USER_DISCARD,
+ DownloadItem::AcquireFileCallback());
// WARNING: we are deleted at this point. Don't access 'this'.
} else if (save_button_ && sender == save_button_) {
// The user has confirmed a dangerous download. We'd record how quickly the
@@ -534,7 +536,7 @@ void DownloadItemView::ButtonPressed(
UMA_HISTOGRAM_LONG_TIMES("clickjacking.save_download",
base::Time::Now() - creation_time_);
// This will change the state and notify us.
- download()->DangerousDownloadValidated();
+ download()->ValidateDangerousDownload();
}
}

Powered by Google App Engine
This is Rietveld 408576698