Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 14947005: fix nosnapshot test failure in 14793004, do not deprecate function (Closed)

Created:
7 years, 7 months ago by dcarney
Modified:
7 years, 7 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

fix nosnapshot test failure in 14793004, do not deprecate function BUG= TBR=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14585

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+337 lines, -269 lines) Patch
M samples/process.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/d8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/d8.cc View 7 chunks +34 lines, -32 lines 0 comments Download
M src/mksnapshot.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M test/cctest/cctest.h View 1 chunk +8 lines, -2 lines 0 comments Download
M test/cctest/test-api.cc View 59 chunks +136 lines, -135 lines 0 comments Download
M test/cctest/test-debug.cc View 10 chunks +37 lines, -28 lines 0 comments Download
M test/cctest/test-decls.cc View 4 chunks +14 lines, -8 lines 0 comments Download
M test/cctest/test-hashing.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M test/cctest/test-heap.cc View 4 chunks +36 lines, -12 lines 0 comments Download
M test/cctest/test-lockers.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M test/cctest/test-log.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-parsing.cc View 2 chunks +8 lines, -6 lines 0 comments Download
M test/cctest/test-profile-generator.cc View 2 chunks +6 lines, -9 lines 0 comments Download
M test/cctest/test-random.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M test/cctest/test-regexp.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M test/cctest/test-serialize.cc View 7 chunks +29 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
dcarney
Committed patchset #1 manually as r14585 (presubmit successful).
7 years, 7 months ago (2013-05-08 07:45:30 UTC) #1
Sven Panne
7 years, 7 months ago (2013-05-08 08:09:40 UTC) #2
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698