Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1494673004: For non-prototype objects constructed using base==new.target, use the cached constructor to render … (Closed)

Created:
5 years ago by Toon Verwaest
Modified:
5 years ago
Reviewers:
ulan, Camillo Bruni
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

For non-prototype objects constructed using base==new.target, use the cached constructor to render the name. BUG=chromium:563791 LOG=y Committed: https://crrev.com/324ab7076c68bee0e75c0579c6da9c10767e54a3 Cr-Commit-Position: refs/heads/master@{#32556}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -10 lines) Patch
M src/heap/heap.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/objects.cc View 1 5 chunks +24 lines, -8 lines 0 comments Download
M src/objects-inl.h View 1 chunk +8 lines, -0 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-523308.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Toon Verwaest
ptal
5 years ago (2015-12-03 10:21:43 UTC) #2
Camillo Bruni
lgtm with typo nit. https://codereview.chromium.org/1494673004/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/1494673004/diff/1/src/objects.cc#newcode2287 src/objects.cc:2287: // reclaimed and replaced by ...
5 years ago (2015-12-03 11:56:17 UTC) #3
Toon Verwaest
Addressed nit.
5 years ago (2015-12-03 11:57:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1494673004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1494673004/20001
5 years ago (2015-12-03 11:58:14 UTC) #7
ulan
heap part lgtm.
5 years ago (2015-12-03 11:59:22 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-03 12:35:17 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-03 12:41:39 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/324ab7076c68bee0e75c0579c6da9c10767e54a3
Cr-Commit-Position: refs/heads/master@{#32556}

Powered by Google App Engine
This is Rietveld 408576698