Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 149463009: Adding int cast to prevent warning (Closed)

Created:
6 years, 10 months ago by sugoi1
Modified:
6 years, 10 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Adding int cast to prevent warning BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13285

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M samplecode/SamplePictFile.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
sugoi1
6 years, 10 months ago (2014-02-03 18:42:29 UTC) #1
f(malita)
lgtm
6 years, 10 months ago (2014-02-03 18:48:28 UTC) #2
sugoi1
The CQ bit was checked by sugoi@chromium.org
6 years, 10 months ago (2014-02-03 18:48:50 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-03 18:48:52 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 10 months ago (2014-02-03 18:48:53 UTC) #5
sugoi1
bsalomon@: Need lgtm for build fix. Thanks.
6 years, 10 months ago (2014-02-03 18:50:20 UTC) #6
fmalita_google_do_not_use
lgtm Try now.
6 years, 10 months ago (2014-02-03 18:52:51 UTC) #7
fmalita_google_do_not_use
The CQ bit was checked by fmalita@google.com
6 years, 10 months ago (2014-02-03 18:52:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/sugoi@chromium.org/149463009/1
6 years, 10 months ago (2014-02-03 18:53:04 UTC) #9
fmalita_google_do_not_use
Since the tree is closed, you'll probably need to land manually with --bypass-hooks.
6 years, 10 months ago (2014-02-03 18:55:41 UTC) #10
sugoi1
The CQ bit was unchecked by sugoi@chromium.org
6 years, 10 months ago (2014-02-03 19:13:09 UTC) #11
sugoi1
The CQ bit was checked by sugoi@chromium.org
6 years, 10 months ago (2014-02-03 19:13:10 UTC) #12
commit-bot: I haz the power
Change committed as 13285
6 years, 10 months ago (2014-02-03 19:40:37 UTC) #13
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 19:40:38 UTC) #14
commit-bot: I haz the power
6 years, 10 months ago (2014-02-03 19:41:46 UTC) #15
Message was sent while issue was closed. 
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698