Issue 149463005: Exclude Task Manager strings when enable_task_manager==0.

Issue 149463005: Exclude Task Manager strings when enable_task_manager==0. (Closed)

Created:
6 years, 10 months ago by aurimas (slooooooooow)

Modified:
6 years, 10 months ago

Reviewers:
newt (away)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Exclude Task Manager strings when enable_task_manager==0. BUG=326023 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247933

Patch Set 2 : Updated capitalization #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+202 lines, -198 lines)			Patch
	M	build/common.gypi	View		6 chunks	+5 lines, -3 lines	0 comments	Download
	M	chrome/app/generated_resources.grd	View		1 chunk	+197 lines, -195 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

aurimas (slooooooooow)

Hello Newton, Please take a look at this CL. Thanks, Aurimas

6 years, 10 months ago (2014-01-29 21:16:17 UTC) #1

newt (away)

nit (not your fault :), then lgtm https://codereview.chromium.org/149463005/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/149463005/diff/1/chrome/app/generated_resources.grd#newcode3400 chrome/app/generated_resources.grd:3400: + GDI ...

6 years, 10 months ago (2014-01-29 21:43:26 UTC) #2

aurimas (slooooooooow)

https://codereview.chromium.org/149463005/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/149463005/diff/1/chrome/app/generated_resources.grd#newcode3400 chrome/app/generated_resources.grd:3400: + GDI Handles On 2014/01/29 21:43:26, newt wrote: > ...

6 years, 10 months ago (2014-01-29 21:54:26 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/149463005/20001

6 years, 10 months ago (2014-01-29 23:23:06 UTC) #4

commit-bot: I haz the power

CQ bit was unchecked on CL. Ignoring.

6 years, 10 months ago (2014-01-30 03:04:43 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/149463005/20001

6 years, 10 months ago (2014-01-30 03:13:34 UTC) #6

Message was sent while issue was closed.

Change committed as 247933

Expand Messages | Collapse Messages