Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 149463002: [App Shell] Port app_shell to windows aura.(not use) (Closed)

Created:
6 years, 10 months ago by Haojian Wu
Modified:
6 years, 10 months ago
Reviewers:
James Cook, Yoyo Zhou
CC:
chromium-reviews, tfarina, chromium-apps-reviews_chromium.org
Base URL:
https://github.com/mirrors/chromium.git@master
Visibility:
Public.

Description

[App Shell] Port app_shell to windows aura. Allow windows developsers to run app_shell. BUG=None TEST=Build app_shell on windows with use_aura=1, it launches normally.

Patch Set 1 #

Total comments: 6

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -1 line) Patch
M apps/apps.gypi View 2 chunks +13 lines, -1 line 0 comments Download
M apps/shell/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
M apps/shell/shell_main.cc View 1 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Haojian Wu
James@, how about considering this patch? Any plan to port app_shell to windows? It may ...
6 years, 10 months ago (2014-01-29 09:47:33 UTC) #1
James Cook
Let me talk to yoz@ and miket@. Our original plan for app_shell was Chrome OS ...
6 years, 10 months ago (2014-01-29 17:30:27 UTC) #2
James Cook
I talked with Yoyo. Basically, getting app_shell running on Windows is not a priority for ...
6 years, 10 months ago (2014-01-29 20:41:59 UTC) #3
Haojian Wu
I'm ok with that. Thanks. https://codereview.chromium.org/149463002/diff/1/apps/DEPS File apps/DEPS (right): https://codereview.chromium.org/149463002/diff/1/apps/DEPS#newcode12 apps/DEPS:12: "+sandbox", On 2014/01/29 20:42:00, ...
6 years, 10 months ago (2014-01-30 06:28:46 UTC) #4
James Cook
lgtm
6 years, 10 months ago (2014-01-30 17:32:21 UTC) #5
Haojian Wu
The CQ bit was unchecked by hokein.wu@gmail.com
6 years, 10 months ago (2014-01-31 15:07:44 UTC) #6
Haojian Wu
The CQ bit was checked by hokein.wu@gmail.com
6 years, 10 months ago (2014-01-31 15:07:45 UTC) #7
Haojian Wu
On 2014/01/31 15:07:45, Haojian Wu wrote: > The CQ bit was checked by mailto:hokein.wu@gmail.com The ...
6 years, 10 months ago (2014-02-01 12:00:48 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-02 00:32:40 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-02 00:32:42 UTC) #10
commit-bot: I haz the power
6 years, 10 months ago (2014-02-02 00:32:45 UTC) #11
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698