Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1494613002: Reduce number of string allocations in util.cc. (Closed)

Created:
5 years ago by Georges Khalil
Modified:
5 years ago
Reviewers:
mattm
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce number of string allocations in util.cc. Replaces temporary string allocations with StringPiece. BUG= Committed: https://crrev.com/3f9f4d70e8617af2872564d92401f36f0f5c8c8c Cr-Commit-Position: refs/heads/master@{#363054}

Patch Set 1 #

Total comments: 2

Patch Set 2 : mattm@ comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M components/safe_browsing_db/util.cc View 1 1 chunk +9 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Georges Khalil
mattm@, PTAL.
5 years ago (2015-12-02 18:46:26 UTC) #2
mattm
https://codereview.chromium.org/1494613002/diff/1/components/safe_browsing_db/util.cc File components/safe_browsing_db/util.cc (right): https://codereview.chromium.org/1494613002/diff/1/components/safe_browsing_db/util.cc#newcode235 components/safe_browsing_db/util.cc:235: host.set(url_unescaped_str.c_str() + parsed.host.begin, parsed.host.len); .data()
5 years ago (2015-12-03 00:10:55 UTC) #3
Georges Khalil
PTAnL. https://codereview.chromium.org/1494613002/diff/1/components/safe_browsing_db/util.cc File components/safe_browsing_db/util.cc (right): https://codereview.chromium.org/1494613002/diff/1/components/safe_browsing_db/util.cc#newcode235 components/safe_browsing_db/util.cc:235: host.set(url_unescaped_str.c_str() + parsed.host.begin, parsed.host.len); On 2015/12/03 00:10:54, mattm ...
5 years ago (2015-12-03 15:47:37 UTC) #4
mattm
lgtm
5 years ago (2015-12-03 20:47:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1494613002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1494613002/20001
5 years ago (2015-12-03 20:48:18 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-03 20:57:14 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-03 20:59:14 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/3f9f4d70e8617af2872564d92401f36f0f5c8c8c
Cr-Commit-Position: refs/heads/master@{#363054}

Powered by Google App Engine
This is Rietveld 408576698