Record first run startup metrics.

chrome/browser/ui/gtk/first_run_dialog.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/gtk/first_run_dialog.h"
 
 #include <string>
 #include <vector>
 
 #include "base/i18n/rtl.h"
@@ skipping 50 matching lines @@
   g_value_set_int(&value, y);
   gtk_container_child_set_property(GTK_CONTAINER(container),
                                    label, "y", &value);
   g_value_unset(&value);
 }
 
 }  // namespace
 
 namespace first_run {
 
-void ShowFirstRunDialog(Profile* profile) {
-  FirstRunDialog::Show();
+bool ShowFirstRunDialog(Profile* profile) {
+  return FirstRunDialog::Show();
 }
 
 }  // namespace first_run
 
 // static
 bool FirstRunDialog::Show() {
-#if !defined(GOOGLE_CHROME_BUILD)
-  return true;  // Nothing to do
-#else
+  bool dialog_shown = false;
+#if defined(GOOGLE_CHROME_BUILD)
   // If the metrics reporting is managed, we won't ask.
   const PrefService::Preference* metrics_reporting_pref =
       g_browser_process->local_state()->FindPreference(
           prefs::kMetricsReportingEnabled);
   bool show_reporting_dialog = !metrics_reporting_pref ||
       !metrics_reporting_pref->IsManaged();
 
   if (!show_reporting_dialog)
-    return true;  // Nothing to do
+    return;  // Nothing to do

[jeremy, 2013/05/06 17:59:38]

Does this compile?

[gab, 2013/05/06 18:44:51]

Whoops, you're right :) -- I'm on Windows! Cleaned up the interface some more
since |show_reporting_dialog| was already handling the early return and the
|response| was never used.

 
   int response = -1;
   // Object deletes itself.
   new FirstRunDialog(show_reporting_dialog, &response);
+  dialog_shown = true;
 
   // TODO(port): it should be sufficient to just run the dialog:
   // int response = gtk_dialog_run(GTK_DIALOG(dialog));
   // but that spins a nested message loop and hoses us.  :(
   // http://code.google.com/p/chromium/issues/detail?id=12552
-  // Instead, run a loop and extract the response manually.
+  // Instead, run a loop directly here.
   MessageLoop::current()->Run();
-
-  return (response == GTK_RESPONSE_ACCEPT);
 #endif  // defined(GOOGLE_CHROME_BUILD)
+  return dialog_shown;
 }
 
 FirstRunDialog::FirstRunDialog(bool show_reporting_dialog, int* response)
     : dialog_(NULL),
       report_crashes_(NULL),
       make_default_(NULL),
       show_reporting_dialog_(show_reporting_dialog),
       response_(response) {
   ShowReportingDialog();
 }
@@ skipping 92 matching lines @@
 }
 
 void FirstRunDialog::FirstRunDone() {
   first_run::SetShouldShowWelcomePage();
 
   if (dialog_)
     gtk_widget_destroy(dialog_);
   MessageLoop::current()->Quit();
   delete this;
 }