chrome/browser/first_run/first_run_dialog.h - Issue 14946003: Record first run startup metrics.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/first_run/first_run_dialog.h

Issue 14946003: Record first run startup metrics. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_FIRST_RUN_FIRST_RUN_DIALOG_H_	5 #ifndef CHROME_BROWSER_FIRST_RUN_FIRST_RUN_DIALOG_H_

6 #define CHROME_BROWSER_FIRST_RUN_FIRST_RUN_DIALOG_H_	6 #define CHROME_BROWSER_FIRST_RUN_FIRST_RUN_DIALOG_H_

7	7

8 class Profile;	8 class Profile;

9	9

10 namespace first_run {	10 namespace first_run {

11	11

12 // Shows the first run dialog. Only called if IsOrganicFirstRun() is true.	12 // Shows the first run dialog. Only called if IsOrganicFirstRun() is true.

13 void ShowFirstRunDialog(Profile* profile);	13 // Returns true if the dialog was shown.

	14 bool ShowFirstRunDialog(Profile* profile);
	jeremy 2013/05/05 12:35:56 Rather than changing the prototype, can you #ifdef Rather than changing the prototype, can you #ifdef the calling code appropriately and remove the dummy function body for this function? gab 2013/05/06 16:19:54 Removed the views implementation and moved the cal Show quoted text On 2013/05/05 12:35:56, jeremy wrote: > Rather than changing the prototype, can you #ifdef the calling code > appropriately and remove the dummy function body for this function? Removed the views implementation and moved the call to first_run_posix.cc. This also makes it more explicit that it's broken for Linux+Aura (http://crbug.com/234637) -- and also easier to fix since adding a views implementation will no longer trigger this to show on Windows where it shouldn't show (I think the EULA replaces this on Windows). Still modified the interface to return a bool to specify whether the dialog was shown though as there are many cases where it is not shown and this will help us get first run stats on Linux/Mac which we wouldn't get if we just blindly assume that calling this method resulted in a dialog being shown.
14	15

15 } // namespace first_run	16 } // namespace first_run

16	17

17 #endif // CHROME_BROWSER_FIRST_RUN_FIRST_RUN_DIALOG_H_	18 #endif // CHROME_BROWSER_FIRST_RUN_FIRST_RUN_DIALOG_H_

OLD	NEW

« chrome/browser/first_run/first_run.cc ('K') | « chrome/browser/first_run/first_run.cc ('k') | chrome/browser/ui/cocoa/first_run_dialog.mm » ('j') | chrome/common/startup_metric_utils.h » ('J')