Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 1494593005: PPC: Remove new.target value from construct stub frames. (Closed)

Created:
5 years ago by MTBrandyberry
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Remove new.target value from construct stub frames. Port eaa0e59611f437568a81d76b4d7d446b0d4786a6 Original commit message: This drops the specific slot containing the new.target value from our construct stub frames. This side-channel has been deprecated and will no longer be accessed by any consumers. R=mstarzinger@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/65421613021e97b24b3aeca0ca32719e983fbdb8 Cr-Commit-Position: refs/heads/master@{#32584}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -16 lines) Patch
M src/ppc/builtins-ppc.cc View 6 chunks +8 lines, -16 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
MTBrandyberry
5 years ago (2015-12-03 15:58:34 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1494593005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1494593005/1
5 years ago (2015-12-03 16:02:39 UTC) #3
Michael Starzinger
LGTM. Thanks!
5 years ago (2015-12-03 16:10:01 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-03 16:46:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1494593005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1494593005/1
5 years ago (2015-12-03 18:17:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1494593005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1494593005/1
5 years ago (2015-12-03 18:48:01 UTC) #11
john.yan
lgtm
5 years ago (2015-12-03 18:48:28 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 19:36:51 UTC) #13
commit-bot: I haz the power
5 years ago (2015-12-03 19:37:32 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/65421613021e97b24b3aeca0ca32719e983fbdb8
Cr-Commit-Position: refs/heads/master@{#32584}

Powered by Google App Engine
This is Rietveld 408576698