Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 1494533002: Reland of [heap] Unify evacuating an object for new and old generation. (Closed)

Created:
5 years ago by Hannes Payer (out of office)
Modified:
5 years ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of [heap] Unify evacuating an object for new and old generation. (patchset #1 id:1 of https://codereview.chromium.org/1483963004/ ) Reason for revert: Reland after fixing the potential root cause of the canary crasher. Original issue's description: > Revert of [heap] Unify evacuating an object for new and old generation. (patchset #2 id:20001 of https://codereview.chromium.org/1481873002/ ) > > Reason for revert: > Still investigating bad canary. > > Original issue's description: > > [heap] Unify evacuating an object for new and old generation. > > > > BUG=chromium:524425 > > LOG=N > > > > Committed: https://crrev.com/afb8bcce8ba889280ed747eb218d287ddd233b4a > > Cr-Commit-Position: refs/heads/master@{#32365} > > TBR=mlippautz@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:524425 > > Committed: https://crrev.com/9c60ddc60e96da0c59e646660789c26550ad52a2 > Cr-Commit-Position: refs/heads/master@{#32460} TBR=mlippautz@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:524425 Committed: https://crrev.com/7ea8ac98f6eb5ffa9d4976aa22fec9befb814e0c Cr-Commit-Position: refs/heads/master@{#32501}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -56 lines) Patch
M src/heap/mark-compact.h View 3 chunks +4 lines, -6 lines 0 comments Download
M src/heap/mark-compact.cc View 4 chunks +49 lines, -50 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Hannes Payer (out of office)
Created Reland of [heap] Unify evacuating an object for new and old generation.
5 years ago (2015-12-02 11:03:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1494533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1494533002/1
5 years ago (2015-12-02 11:04:03 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-02 11:04:15 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7ea8ac98f6eb5ffa9d4976aa22fec9befb814e0c Cr-Commit-Position: refs/heads/master@{#32501}
5 years ago (2015-12-02 11:04:28 UTC) #5
Michael Lippautz
5 years ago (2015-12-02 14:48:40 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1491013003/ by mlippautz@chromium.org.

The reason for reverting is: Speculative revert for crashing Canary..

Powered by Google App Engine
This is Rietveld 408576698