src/heap/spaces.h - Issue 1494503004: Reland of "[heap] Clean up stale store buffer entries for aborted pages."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/spaces.h

Issue 1494503004: Reland of "[heap] Clean up stale store buffer entries for aborted pages." (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Reorder sweeping (on main thread) and store buffer fixup phase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap/spaces.h

diff --git a/src/heap/spaces.h b/src/heap/spaces.h

index 5e473426028dc6dc3d21b931013781471a051836..0e5fdef82d602ba72512a5bc2ff4f79268f85926 100644

--- a/src/heap/spaces.h

+++ b/src/heap/spaces.h

@@ -328,7 +328,8 @@ class MemoryChunk {

PRE_FREED,

// |COMPACTION_WAS_ABORTED|: Indicates that the compaction in this page

- // has been aborted and needs special handling by the sweeper.

+ // has been aborted and needs special handling, i.e., sweeper and store

+ // buffer.

COMPACTION_WAS_ABORTED,

// Last flag, keep at bottom.

« src/heap/mark-compact.cc ('K') | « src/heap/mark-compact.cc ('k') | no next file » | no next file with comments »