Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issue 1494503003: Mark BooleanObject::New() as deprecated (Closed)

Created:
5 years ago by jochen (gone - plz use gerrit)
Modified:
5 years ago
Reviewers:
vogelheim
CC:
Paweł Hajdan Jr., v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Mark BooleanObject::New() as deprecated Embedders should use the factory method that takes an Isolate* instead BUG=none R=vogelheim@chromium.org LOG=y Committed: https://crrev.com/ef3bee66d113d49a9d381b408603fcc04cc3b5ad Cr-Commit-Position: refs/heads/master@{#32573}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
jochen (gone - plz use gerrit)
5 years ago (2015-12-02 08:36:26 UTC) #1
jochen (gone - plz use gerrit)
ptal
5 years ago (2015-12-02 13:12:45 UTC) #2
vogelheim
lgtm v8_linux_chromium_gn_rel bot says ScriptValueSerializer.cpp:1196 wants your attention first. Otherwise looks good.
5 years ago (2015-12-02 14:36:17 UTC) #3
jochen (gone - plz use gerrit)
On 2015/12/02 at 14:36:17, vogelheim wrote: > lgtm > > v8_linux_chromium_gn_rel bot says ScriptValueSerializer.cpp:1196 wants ...
5 years ago (2015-12-02 15:12:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1494503003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1494503003/1
5 years ago (2015-12-03 15:10:23 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 15:32:26 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-03 15:32:42 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ef3bee66d113d49a9d381b408603fcc04cc3b5ad
Cr-Commit-Position: refs/heads/master@{#32573}

Powered by Google App Engine
This is Rietveld 408576698