Issue 14945006: Revert "Avoid adding placeholder when deleting last text in root"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14945006: Revert "Avoid adding placeholder when deleting last text in root" (Closed)

Created:
7 years, 7 months ago by Stephen White

Modified:
7 years, 7 months ago

Reviewers:
leviw_travelin_and_unemployed

CC:
blink-reviews, eae+blinkwatch, adamk+blink_chromium.org, ojan

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Revert "Avoid adding placeholder when deleting last text in root" This reverts commit 1f2942f421299e054bd3f2b47ea81efeced5746a. BUG=222806, 236726 TBR=leviw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150434

Patch Set 1 #

Patch Set 2 : (second upload attempt) #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+69 lines, -55 lines)			Patch
M	LayoutTests/TestExpectations	View	2 chunks	+1 line, -16 lines	0 comments	Download
	LayoutTests/editing/deleting/5847330-2-expected.txt	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	LayoutTests/editing/deleting/delete-3775172-fix-expected.txt	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	LayoutTests/editing/deleting/delete-across-editable-content-boundaries-1-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/editing/deleting/delete-all-text-in-text-field-assertion-expected.txt	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	LayoutTests/editing/deleting/delete-and-cleanup.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/editing/deleting/delete-and-cleanup-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/editing/deleting/delete-block-merge-contents-025-expected.txt	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	LayoutTests/editing/deleting/delete-select-all-002-expected.txt	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	LayoutTests/editing/deleting/delete-start-block-expected.txt	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	LayoutTests/editing/deleting/paste-with-transparent-background-color-expected.txt	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	LayoutTests/editing/execCommand/create-list-with-hr-expected.txt	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	LayoutTests/editing/execCommand/forward-delete-no-scroll-expected.txt	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	LayoutTests/editing/execCommand/insertHTML-expected.txt	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	LayoutTests/editing/pasteboard/copy-paste-content-starting-and-ending-canvas-expected.txt	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	LayoutTests/editing/pasteboard/select-element-1-expected.txt	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	LayoutTests/editing/spelling/spellcheck-paste-continuous-disabled-expected.txt	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	LayoutTests/fast/events/event-input-contentEditable-expected.txt	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	LayoutTests/fast/events/script-tests/event-input-contentEditable.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	LayoutTests/fast/parser/nested-fragment-parser-crash-expected.txt	View	1 chunk	+0 lines, -3 lines	0 comments	Download
	LayoutTests/platform/chromium-win/editing/deleting/5272440-expected.txt	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	LayoutTests/platform/chromium-win/editing/deleting/delete-3775172-fix-expected.txt	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	LayoutTests/platform/chromium-win/editing/deleting/delete-all-text-in-text-field-assertion-expected.txt	View	1 chunk	+1 line, -0 lines	0 comments	Download
	LayoutTests/platform/chromium-win/editing/deleting/delete-block-contents-001-expected.txt	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	LayoutTests/platform/chromium-win/editing/deleting/delete-block-contents-002-expected.txt	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	LayoutTests/platform/chromium-win/editing/deleting/delete-block-contents-003-expected.txt	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	LayoutTests/platform/chromium-win/editing/deleting/delete-image-004-expected.txt	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	LayoutTests/platform/chromium-win/editing/execCommand/create-list-with-hr-expected.txt	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	LayoutTests/platform/chromium-win/editing/inserting/insert-3775316-fix-expected.txt	View	1 chunk	+2 lines, -1 line	0 comments	Download
	LayoutTests/platform/chromium-win/editing/inserting/insert-after-delete-001-expected.txt	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	LayoutTests/platform/chromium-win/editing/pasteboard/4076267-3-expected.txt	View	1 chunk	+2 lines, -1 line	0 comments	Download
	LayoutTests/platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.txt	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	LayoutTests/platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.txt	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	Source/core/editing/DeleteSelectionCommand.cpp	View	1 chunk	+3 lines, -6 lines	0 comments	Download
M	Source/core/html/HTMLInputElement.cpp	View	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #2 manually as r150434.

Expand Messages | Collapse Messages