Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1494453002: X87: [debugger] Remove code to predict step-in target. (Closed)

Created:
5 years ago by zhengxing.li
Modified:
5 years ago
Reviewers:
Weiliang, chunyang.dai, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [debugger] Remove code to predict step-in target. port 2f559f210d5a6fd60ab8471c0bd3f924a5a8f450 (r32449) original commit message: BUG= Committed: https://crrev.com/ee29b94a839dd63155f0ca99d9c83e4702cb1d93 Cr-Commit-Position: refs/heads/master@{#32487}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M src/x87/macro-assembler-x87.cc View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
5 years ago (2015-12-02 03:16:37 UTC) #2
Weiliang
lgtm
5 years ago (2015-12-02 05:02:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1494453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1494453002/1
5 years ago (2015-12-02 05:02:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-02 05:23:07 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-02 05:23:49 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ee29b94a839dd63155f0ca99d9c83e4702cb1d93
Cr-Commit-Position: refs/heads/master@{#32487}

Powered by Google App Engine
This is Rietveld 408576698