Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(794)

Unified Diff: build/config/nacl/rules.gni

Issue 1494423002: GN: Build Non-SFI version of NaCl browser tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Pass the nmf flags to non-SFI script Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/nacl/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/nacl/rules.gni
diff --git a/build/config/nacl/rules.gni b/build/config/nacl/rules.gni
index 5801d45795b6882bcd05a80506d17bb133c9823d..0a9ac1ffb7dcf1ce53695183d3fae12be8d6288b 100644
--- a/build/config/nacl/rules.gni
+++ b/build/config/nacl/rules.gni
@@ -113,17 +113,21 @@ template("generate_nmf") {
# Variables:
# executable: Non-SFI .nexe executable to generate nmf for
# nmf: the name and the path of the output file
+# nmfflags: additional flags for the nmf generator
template("generate_nonsfi_test_nmf") {
assert(defined(invoker.executable), "Must define executable")
assert(defined(invoker.nmf), "Must define nmf")
action(target_name) {
+ nmfflags = []
+
forward_variables_from(invoker,
[
"deps",
"data_deps",
"executable",
"nmf",
+ "nmfflags",
"testonly",
"public_deps",
])
@@ -147,9 +151,9 @@ template("generate_nonsfi_test_nmf") {
arch = target_cpu
}
args = [
- "--program=" + rebase_path(executable, root_build_dir),
- "--arch=${arch}",
- "--output=" + rebase_path(nmf, root_build_dir),
- ]
+ "--program=" + rebase_path(executable, root_build_dir),
+ "--arch=${arch}",
+ "--output=" + rebase_path(nmf, root_build_dir),
+ ] + nmfflags
}
}
« no previous file with comments | « no previous file | chrome/test/data/nacl/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698