Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1494423002:
GN: Build Non-SFI version of NaCl browser tests (Closed)
|
Created:
5 years ago by Petr Hosek Modified:
5 years ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionGN: Build Non-SFI version of NaCl browser tests
Non-SFI uses PNaCl toolchain, but pexes need to be pre-translated
for the target platform, and the nmf format is different hence
requiring a different action.
BUG=462791
Committed: https://crrev.com/92e64362e9e2f615b1aef34c069ce78a3713dfe0
Cr-Commit-Position: refs/heads/master@{#364442}
Patch Set 1 : #Patch Set 2 : Avoid the extra nesting #Patch Set 3 : Pass the nmf flags to non-SFI script #
Messages
Total messages: 24 (15 generated)
Description was changed from ========== GN: build Non-SFI version of browser tests BUG=462791 ========== to ========== GN: Build Non-SFI version of browser tests BUG=462791 ==========
phosek@chromium.org changed reviewers: + bradnelson@chromium.org, brettw@chromium.org, dpranke@chromium.org, mcgrathr@chromium.org
Description was changed from ========== GN: Build Non-SFI version of browser tests BUG=462791 ========== to ========== GN: Build Non-SFI version of browser tests Non-SFI uses PNaCl toolchain, but pexes need to be pre-translated for the target platform, and the nmf format is different hence requiring a different action. BUG=462791 ==========
Patchset #1 (id:1) has been deleted
Description was changed from ========== GN: Build Non-SFI version of browser tests Non-SFI uses PNaCl toolchain, but pexes need to be pre-translated for the target platform, and the nmf format is different hence requiring a different action. BUG=462791 ========== to ========== GN: Build Non-SFI version of NaCl browser tests Non-SFI uses PNaCl toolchain, but pexes need to be pre-translated for the target platform, and the nmf format is different hence requiring a different action. BUG=462791 ==========
lgtm
rubber-stamp lgtm :).
Roland, do you want to take a look or shall I land this as is?
I don't see any problems off hand but it's mostly Greek to me.
The CQ bit was checked by phosek@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1494423002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1494423002/40001
The CQ bit was unchecked by phosek@chromium.org
The CQ bit was checked by phosek@chromium.org
The CQ bit was unchecked by phosek@chromium.org
The CQ bit was checked by phosek@chromium.org
The CQ bit was unchecked by phosek@chromium.org
The CQ bit was checked by phosek@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org, bradnelson@chromium.org Link to the patchset: https://codereview.chromium.org/1494423002/#ps60001 (title: "Pass the nmf flags to non-SFI script")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1494423002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1494423002/60001
Message was sent while issue was closed.
Description was changed from ========== GN: Build Non-SFI version of NaCl browser tests Non-SFI uses PNaCl toolchain, but pexes need to be pre-translated for the target platform, and the nmf format is different hence requiring a different action. BUG=462791 ========== to ========== GN: Build Non-SFI version of NaCl browser tests Non-SFI uses PNaCl toolchain, but pexes need to be pre-translated for the target platform, and the nmf format is different hence requiring a different action. BUG=462791 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== GN: Build Non-SFI version of NaCl browser tests Non-SFI uses PNaCl toolchain, but pexes need to be pre-translated for the target platform, and the nmf format is different hence requiring a different action. BUG=462791 ========== to ========== GN: Build Non-SFI version of NaCl browser tests Non-SFI uses PNaCl toolchain, but pexes need to be pre-translated for the target platform, and the nmf format is different hence requiring a different action. BUG=462791 Committed: https://crrev.com/92e64362e9e2f615b1aef34c069ce78a3713dfe0 Cr-Commit-Position: refs/heads/master@{#364442} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/92e64362e9e2f615b1aef34c069ce78a3713dfe0 Cr-Commit-Position: refs/heads/master@{#364442} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
