chrome/browser/notifications/sync_notifier/synced_notification_unittest.cc - Issue 149433005: Adds a small icon to notifications, and connects it to synced notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/sync_notifier/synced_notification_unittest.cc

Issue 149433005: Adds a small icon to notifications, and connects it to synced notifications. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address nits Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/notifications/notification.h ('K') | « chrome/browser/notifications/sync_notifier/synced_notification.cc ('k') | ui/message_center/cocoa/notification_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/sync_notifier/synced_notification_unittest.cc

diff --git a/chrome/browser/notifications/sync_notifier/synced_notification_unittest.cc b/chrome/browser/notifications/sync_notifier/synced_notification_unittest.cc

index cbb5c6102d15277d440a0927161093596728a3b4..6dd09901ac92eed4877747b91443e6e759cedfe7 100644

--- a/chrome/browser/notifications/sync_notifier/synced_notification_unittest.cc

+++ b/chrome/browser/notifications/sync_notifier/synced_notification_unittest.cc

@@ -330,6 +330,10 @@ TEST_F(SyncedNotificationTest, OnFetchCompleteTest) {

notification1_->OnFetchComplete(GURL(kButtonTwoIconUrl), &bitmap);

+ // Expect that the app icon has some data in it.

+ EXPECT_FALSE(notification1_->GetAppIcon().IsEmpty());

+ EXPECT_FALSE(notification_manager()->notification().small_image().IsEmpty());

// Since we check Show() thoroughly in its own test, we only check cursorily.

EXPECT_EQ(message_center::NOTIFICATION_TYPE_IMAGE,

notification_manager()->notification().type());