Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 149433004: Add libpulseaudio and libasound to instrumented libraries. (Closed)

Created:
6 years, 10 months ago by earthdok
Modified:
6 years, 10 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add libpulseaudio and libasound to instrumented libraries. BUG=313751 R=glider@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247936

Patch Set 1 #

Total comments: 1

Patch Set 2 : add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -9 lines) Patch
M third_party/instrumented_libraries/instrumented_libraries.gyp View 2 chunks +15 lines, -0 lines 0 comments Download
A + third_party/instrumented_libraries/libasound2.sh View 1 chunk +5 lines, -2 lines 0 comments Download
A third_party/instrumented_libraries/pulseaudio.diff View 1 1 chunk +16 lines, -0 lines 0 comments Download
A + third_party/instrumented_libraries/pulseaudio.sh View 1 chunk +3 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
earthdok
ptal
6 years, 10 months ago (2014-01-29 20:51:10 UTC) #1
Alexander Potapenko
LGTM with a nit https://codereview.chromium.org/149433004/diff/1/third_party/instrumented_libraries/pulseaudio.diff File third_party/instrumented_libraries/pulseaudio.diff (right): https://codereview.chromium.org/149433004/diff/1/third_party/instrumented_libraries/pulseaudio.diff#newcode7 third_party/instrumented_libraries/pulseaudio.diff:7: #if defined(__GNUC__) && (defined(__i386__) || ...
6 years, 10 months ago (2014-01-30 08:47:39 UTC) #2
earthdok
On 2014/01/30 08:47:39, Alexander Potapenko wrote: > LGTM with a nit > > https://codereview.chromium.org/149433004/diff/1/third_party/instrumented_libraries/pulseaudio.diff > ...
6 years, 10 months ago (2014-01-30 13:03:47 UTC) #3
earthdok
6 years, 10 months ago (2014-01-30 13:10:59 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r247936 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698