Adjust google_toolbox_for_mac.gyp to meet the needs of iOS.

Adjust google_toolbox_for_mac.gyp to meet the needs of iOS.

TBR=darin

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247728

[Mark Mentovai, 2014-01-29 14:27:05]

LGTM

https://codereview.chromium.org/149433003/diff/1/third_party/google_toolbox_f...
File third_party/google_toolbox_for_mac/google_toolbox_for_mac.gyp (right):

https://codereview.chromium.org/149433003/diff/1/third_party/google_toolbox_f...
third_party/google_toolbox_for_mac/google_toolbox_for_mac.gyp:208:
'src/iPhone/GTMFadeTruncatingLabel.h',
Why don’t we put all of these into the main 'sources' list and then stick an
exclude pattern for '^src/iPhone/' into the OS!="ios" block above?

https://codereview.chromium.org/149433003/diff/1/third_party/google_toolbox_f...
third_party/google_toolbox_for_mac/google_toolbox_for_mac.gyp:220: ['include',
'^src/DebugUtils/GTMMethodCheck\\.m'],
Anchor the ends of these include regular expressions with $.

[blundell, 2014-01-29 14:45:55]

Thanks! Could you take one more quick look over the diff?

https://codereview.chromium.org/149433003/diff/1/third_party/google_toolbox_f...
File third_party/google_toolbox_for_mac/google_toolbox_for_mac.gyp (right):

https://codereview.chromium.org/149433003/diff/1/third_party/google_toolbox_f...
third_party/google_toolbox_for_mac/google_toolbox_for_mac.gyp:208:
'src/iPhone/GTMFadeTruncatingLabel.h',
On 2014/01/29 14:27:06, Mark Mentovai wrote:
> Why don’t we put all of these into the main 'sources' list and then stick an
> exclude pattern for '^src/iPhone/' into the OS!="ios" block above?

Done.

https://codereview.chromium.org/149433003/diff/1/third_party/google_toolbox_f...
third_party/google_toolbox_for_mac/google_toolbox_for_mac.gyp:220: ['include',
'^src/DebugUtils/GTMMethodCheck\\.m'],
On 2014/01/29 14:27:06, Mark Mentovai wrote:
> Anchor the ends of these include regular expressions with $.

Done.

[Mark Mentovai, 2014-01-29 14:51:57]

LGTM

[commit-bot: I haz the power, 2014-01-29 14:54:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/blundell@chromium.org/149433003/20001

[commit-bot: I haz the power, 2014-01-29 15:24:03]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[blundell, 2014-01-29 15:30:36]

TBR=darin

[commit-bot: I haz the power, 2014-01-29 15:31:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/blundell@chromium.org/149433003/20001

[darin (slow to review), 2014-01-29 17:31:29]

OK, LGTM (I guess)

Shouldn't there be an OWNERS file for third_party/google_toolbox_for_mac/ ?

[Mark Mentovai, 2014-01-29 17:34:52]

Until recently, it wasn’t possible (or necessary) to have an OWNERS file for
GTM, because we pulled the entire thing into third_party/GTM by DEPS. This
changed in https://codereview.chromium.org/107933006, and we now check out into
third_party/google_toolbox_for_mac/src. It’s now possible to add
third_party/google_toolbox_for_mac/OWNERS.

[darin (slow to review), 2014-01-29 17:45:20]

OK, makes sense. Who should be in that OWNERS file? Can someone make it
happen?

Thanks!
-Darin


On Wed, Jan 29, 2014 at 9:34 AM, <mark@chromium.org> wrote:

> Until recently, it wasn't possible (or necessary) to have an OWNERS file
> for
> GTM, because we pulled the entire thing into third_party/GTM by DEPS. This
> changed in https://codereview.chromium.org/107933006, and we now check
> out into
> third_party/google_toolbox_for_mac/src. It's now possible to add
> third_party/google_toolbox_for_mac/OWNERS.
>
> https://codereview.chromium.org/149433003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2014-01-29 18:56:57]

Change committed as 247728

[Mark Mentovai, 2014-01-29 20:03:06]

OWNERS file: https://codereview.chromium.org/149683003/