Componentize strings from generated_resources needed by LocalizedError

Componentize strings from generated_resources needed by LocalizedError

LocalizedError, which is due for componentization to be shared on iOS, uses
several strings from generated_resources.grd that are not themselves specific
to error pages (and thus don't belong in //components/error_pages.grdp). This
CL componentizes them into appropriately-named grdp files under //components.

BUG=523362
Committed: https://crrev.com/f2ff0d9653906a9c1205e381aaabffcf7ab29ec5
Cr-Commit-Position: refs/heads/master@{#364016}

[blundell, 2015-12-07 11:51:18]

blundell@chromium.org changed reviewers:
+ jochen@chromium.org

[blundell, 2015-12-07 11:51:19]

The Android compile failures are due to the fact that these strings are used in
Java, and components_strings.grd doesn't currently handle that properly. There's
another in-flight CL to fix that.

[jochen (gone - plz use gerrit), 2015-12-07 15:34:51]

I vaguely remember that there was some problem when moving strings around, like
the strings don't show up in the translation console or something?

[jochen (gone - plz use gerrit), 2015-12-07 15:36:36]

jochen@chromium.org changed reviewers:
+ mmenke@chromium.org

[jochen (gone - plz use gerrit), 2015-12-07 15:36:37]

Maybe mmenke@ remembers

[blundell, 2015-12-07 15:36:39]

On 2015/12/07 15:34:51, jochen wrote:
> I vaguely remember that there was some problem when moving strings around,
like
> the strings don't show up in the translation console or something?

That has since been fixed so that it is no longer necessary to make TC changes
when creating new grdp files as long as they go into an existing grd file.

[blundell, 2015-12-07 16:02:59]

blundell@chromium.org changed reviewers:
+ newt@chromium.org

[blundell, 2015-12-07 16:02:59]

+newt@

Newt, can you confirm my understanding that adding a new grdp file to an
existing grd file no longer requires any TC-side changes for the strings in the
new grdp file to be translated?

[mmenke, 2015-12-07 17:42:33]

This LGTM.  I don't know anything about issues with moving strings around.

[newt (away), 2015-12-07 21:32:45]

On 2015/12/07 16:02:59, blundell wrote:
> +newt@
> 
> Newt, can you confirm my understanding that adding a new grdp file to an
> existing grd file no longer requires any TC-side changes for the strings in
the
> new grdp file to be translated?

Yes. Moving strings around between grd/grdp files is A-OK as long as you don't
change the string content. The translation console identifies strings using a
hash of their content, so avoid changing the content and you're fine.

[jochen (gone - plz use gerrit), 2015-12-08 08:28:56]

lgtm

[blundell, 2015-12-09 07:03:11]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2015-12-09 07:03:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1494293004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1494293004/40001

[commit-bot: I haz the power, 2015-12-09 08:59:46]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-09 09:00:39]

Description was changed from

==========
Componentize strings from generated_resources needed by LocalizedError

LocalizedError, which is due for componentization to be shared on iOS, uses
several strings from generated_resources.grd that are not themselves specific
to error pages (and thus don't belong in //components/error_pages.grdp). This
CL componentizes them into appropriately-named grdp files under //components.

BUG=523362
==========

to

==========
Componentize strings from generated_resources needed by LocalizedError

LocalizedError, which is due for componentization to be shared on iOS, uses
several strings from generated_resources.grd that are not themselves specific
to error pages (and thus don't belong in //components/error_pages.grdp). This
CL componentizes them into appropriately-named grdp files under //components.

BUG=523362

Committed: https://crrev.com/f2ff0d9653906a9c1205e381aaabffcf7ab29ec5
Cr-Commit-Position: refs/heads/master@{#364016}
==========

[commit-bot: I haz the power, 2015-12-09 09:00:40]

Patchset 3 (id:??) landed as
https://crrev.com/f2ff0d9653906a9c1205e381aaabffcf7ab29ec5
Cr-Commit-Position: refs/heads/master@{#364016}