Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 1494273002: CFI: fix invalid cast in tile_manager_unittest.cc. (Closed)

Created:
5 years ago by krasin
Modified:
5 years ago
Reviewers:
reveman
CC:
cc-bugs_chromium.org, chromium-reviews, ericrk, kcc, pcc
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CFI: fix invalid cast in tile_manager_unittest.cc. TaskSetFinishedTaskImpl was casted to its sibling, cc::RasterTask instead of a base class, cc::TileTask. This is a follow up to https://codereview.chromium.org/1470113002 which introduced this bad cast. BUG=565515, 464797 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/1fd302ba896e0a925c8c6b53432de98111074737 Cr-Commit-Position: refs/heads/master@{#363063}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M cc/tiles/tile_manager_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
krasin
Please, review this tiny fix. :)
5 years ago (2015-12-03 20:07:37 UTC) #4
reveman
lgtm
5 years ago (2015-12-03 20:25:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1494273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1494273002/1
5 years ago (2015-12-03 20:27:38 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 21:19:18 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-03 21:21:13 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1fd302ba896e0a925c8c6b53432de98111074737
Cr-Commit-Position: refs/heads/master@{#363063}

Powered by Google App Engine
This is Rietveld 408576698