Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 1494263003: Revert of win/clang: Lame workaround for a compiler bug. (Closed)

Created:
5 years ago by Nico
Modified:
5 years ago
Reviewers:
estark
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of win/clang: Lame workaround for a compiler bug. (patchset #1 id:1 of https://codereview.chromium.org/1410293007/ ) Reason for revert: The compiler bug should now be fixed. Original issue's description: > win/clang: Lame workaround for a compiler bug. > > No intended behavior change, but it should get the clang/win tester > bots back green while this is being fixed upstream. Hopefully it > won't be in the tree for too long. > > BUG=549765 > > Committed: https://crrev.com/12293c13ad9e63c152e0f6909085e9a2f01474ee > Cr-Commit-Position: refs/heads/master@{#357296} TBR=estark@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=549765 Committed: https://crrev.com/45dbe8390e8b0f5b8732bcdefe6e3f097c059298 Cr-Commit-Position: refs/heads/master@{#363079}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M chrome/browser/ui/browser_browsertest.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Nico
Created Revert of win/clang: Lame workaround for a compiler bug.
5 years ago (2015-12-03 23:44:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1494263003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1494263003/1
5 years ago (2015-12-03 23:48:17 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 23:52:24 UTC) #3
commit-bot: I haz the power
5 years ago (2015-12-03 23:53:27 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/45dbe8390e8b0f5b8732bcdefe6e3f097c059298
Cr-Commit-Position: refs/heads/master@{#363079}

Powered by Google App Engine
This is Rietveld 408576698