Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1494253002: Update documentation for SkTypeface constructors. (Closed)

Created:
5 years ago by erikchen
Modified:
5 years ago
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Update documentation for SkFontMgr methods. The appropriate way to get the default system font is to pass |nullptr| as the familyName. This was not clear from the interface, which may be why ui/gfx/ has the wrong behavior. BUG=chromium:564266 Committed: https://skia.googlesource.com/skia/+/2b1516fe35155e05331ca6d4f09be916dc1fd778

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M include/ports/SkFontMgr.h View 3 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
erikchen
bungeman: Please review.
5 years ago (2015-12-03 18:36:34 UTC) #3
reed1
nice addition. lgtm. nit: Specifically, we match for the system default family, and still apply ...
5 years ago (2015-12-03 19:41:38 UTC) #5
bungeman-skia
This lgtm, but we also will need to make sure we have tests for this ...
5 years ago (2015-12-03 19:50:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1494253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1494253002/1
5 years ago (2015-12-03 19:56:46 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-03 20:12:17 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2b1516fe35155e05331ca6d4f09be916dc1fd778

Powered by Google App Engine
This is Rietveld 408576698