Converted remaining tests to use gmock and deleted all old mocking code.

Converted remaining tests to use gmock and deleted all old mocking code.

The most important part was refactoring PipelineImpl tests in preparation for message loop injection.  The old mocks just did not work *at all* with my message loop injection patch.

BUG=16008
TEST=media_unittests should pass and not flake out

[scherkus (not reviewing), 2009-07-09 22:52:48]

The last of the test refactoring...

everything is cleaned up and our tests are even better now

[Alpha Left Google, 2009-07-10 17:23:39]

LGTM, just a few nits.

http://codereview.chromium.org/149423/diff/1/3
File media/base/mock_ffmpeg.cc (right):

http://codereview.chromium.org/149423/diff/1/3#newcode29
Line 29: if (!protocol_) {
this part looks quite nasty.. but if you feel this is the right way I'm ok with
it.

http://codereview.chromium.org/149423/diff/1/7
File media/base/pipeline_impl_unittest.cc (right):

http://codereview.chromium.org/149423/diff/1/7#newcode296
Line 296: float expected = 0.5f;
float kVolume?

http://codereview.chromium.org/149423/diff/1/7#newcode301
Line 301: pipeline_.SetVolume(expected);
what about expect on GetVolume()?

http://codereview.chromium.org/149423/diff/1016/1019
File media/base/mock_filters.h (right):

http://codereview.chromium.org/149423/diff/1016/1019#newcode103
Line 103: media_format_.SetAsString(MediaFormat::kMimeType, mime_type);
I find it may simplify the code a bit in pipeline_impl_unittest.cc if you add a
constructor to assign mime_type to |media_format_|. It seems to me this class is
mostly used like that.

http://codereview.chromium.org/149423/diff/1016/1023
File media/filters/ffmpeg_glue_unittest.cc (right):

http://codereview.chromium.org/149423/diff/1016/1023#newcode103
Line 103: // Remove the data sources and then releases our references.  They
should be
nit: Removes

[scherkus (not reviewing), 2009-07-10 18:51:49]

http://codereview.chromium.org/149423/diff/1016/1019
File media/base/mock_filters.h (right):

http://codereview.chromium.org/149423/diff/1016/1019#newcode103
Line 103: media_format_.SetAsString(MediaFormat::kMimeType, mime_type);
On 2009/07/10 17:23:39, Alpha wrote:
> I find it may simplify the code a bit in pipeline_impl_unittest.cc if you add
a
> constructor to assign mime_type to |media_format_|. It seems to me this class
is
> mostly used like that. 

I like it!  DONE!

http://codereview.chromium.org/149423/diff/1016/1023
File media/filters/ffmpeg_glue_unittest.cc (right):

http://codereview.chromium.org/149423/diff/1016/1023#newcode103
Line 103: // Remove the data sources and then releases our references.  They
should be
On 2009/07/10 17:23:39, Alpha wrote:
> nit: Removes

Done.

[awong, 2009-07-10 19:38:29]

LGTM

2 small nitpicks.

http://codereview.chromium.org/149423/diff/28/31
File media/base/mock_filters.h (right):

http://codereview.chromium.org/149423/diff/28/31#newcode218
Line 218: is_creating_ = is_creating;
is_creating_ is a strange name for something that flags if creation was
successful.  Do you want creation_successful_?

http://codereview.chromium.org/149423/diff/28/34
File media/base/video_frame_impl_unittest.cc (right):

http://codereview.chromium.org/149423/diff/28/34#newcode93
Line 93: TEST(VideoFrameImpl, Implementation) {
not a great name.. do you mean CreateFame?

http://codereview.chromium.org/149423/diff/28/35
File media/filters/ffmpeg_glue_unittest.cc (right):

http://codereview.chromium.org/149423/diff/28/35#newcode182
Line 182: EXPECT_EQ(AVERROR_IO, protocol_->url_write(&context, buffer, -1));
What does -1 do?

[Alpha Left Google, 2009-07-10 20:40:47]

LGTM after ajwong's concerns are addressed.

[scherkus (not reviewing), 2009-07-10 20:45:41]

http://codereview.chromium.org/149423/diff/28/31
File media/base/mock_filters.h (right):

http://codereview.chromium.org/149423/diff/28/31#newcode218
Line 218: is_creating_ = is_creating;
On 2009/07/10 19:38:29, awong wrote:
> is_creating_ is a strange name for something that flags if creation was
> successful.  Do you want creation_successful_?

Done.

http://codereview.chromium.org/149423/diff/28/34
File media/base/video_frame_impl_unittest.cc (right):

http://codereview.chromium.org/149423/diff/28/34#newcode93
Line 93: TEST(VideoFrameImpl, Implementation) {
On 2009/07/10 19:38:29, awong wrote:
> not a great name.. do you mean CreateFame?

Done.

http://codereview.chromium.org/149423/diff/28/35
File media/filters/ffmpeg_glue_unittest.cc (right):

http://codereview.chromium.org/149423/diff/28/35#newcode182
Line 182: EXPECT_EQ(AVERROR_IO, protocol_->url_write(&context, buffer, -1));
On 2009/07/10 19:38:29, awong wrote:
> What does -1 do?

nothing!  removed