Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3010)

Unified Diff: cc/playback/transform_display_item.cc

Issue 1494223003: cc: Shrink size of display item (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make SetNew private Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/playback/transform_display_item.cc
diff --git a/cc/playback/transform_display_item.cc b/cc/playback/transform_display_item.cc
index f841854f9d268311224fbc7010a16a28277c2794..361705ca7e84e9ffd9976f91a2145144390c0c00 100644
--- a/cc/playback/transform_display_item.cc
+++ b/cc/playback/transform_display_item.cc
@@ -12,8 +12,13 @@
namespace cc {
-TransformDisplayItem::TransformDisplayItem()
+TransformDisplayItem::TransformDisplayItem(const gfx::Transform& transform)
: transform_(gfx::Transform::kSkipInitialization) {
+ SetNew(transform);
+}
+
+TransformDisplayItem::TransformDisplayItem(const proto::DisplayItem& proto) {
+ FromProtobuf(proto);
}
TransformDisplayItem::~TransformDisplayItem() {
@@ -21,9 +26,6 @@ TransformDisplayItem::~TransformDisplayItem() {
void TransformDisplayItem::SetNew(const gfx::Transform& transform) {
transform_ = transform;
-
- DisplayItem::SetNew(true /* suitable_for_gpu_raster */, 1 /* op_count */,
- 0 /* external_memory_usage */);
}
void TransformDisplayItem::ToProtobuf(proto::DisplayItem* proto) const {
@@ -58,9 +60,15 @@ void TransformDisplayItem::AsValueInto(
transform_.ToString().c_str(), visual_rect.ToString().c_str()));
}
-EndTransformDisplayItem::EndTransformDisplayItem() {
- DisplayItem::SetNew(true /* suitable_for_gpu_raster */, 0 /* op_count */,
- 0 /* external_memory_usage */);
+size_t TransformDisplayItem::ExternalMemoryUsage() const {
+ return 0;
+}
+
+EndTransformDisplayItem::EndTransformDisplayItem() {}
+
+EndTransformDisplayItem::EndTransformDisplayItem(
+ const proto::DisplayItem& proto) {
+ FromProtobuf(proto);
}
EndTransformDisplayItem::~EndTransformDisplayItem() {
@@ -89,4 +97,8 @@ void EndTransformDisplayItem::AsValueInto(
visual_rect.ToString().c_str()));
}
+size_t EndTransformDisplayItem::ExternalMemoryUsage() const {
+ return 0;
+}
+
} // namespace cc

Powered by Google App Engine
This is Rietveld 408576698