Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1816)

Unified Diff: cc/playback/float_clip_display_item.cc

Issue 1494223003: cc: Shrink size of display item (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make SetNew private Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/playback/float_clip_display_item.cc
diff --git a/cc/playback/float_clip_display_item.cc b/cc/playback/float_clip_display_item.cc
index ae8e0b5d21219e9867c7ca4e5d851bf9033f9a84..addf81b9c79bc6d9d7a645c0e6680ef2bf25f6a3 100644
--- a/cc/playback/float_clip_display_item.cc
+++ b/cc/playback/float_clip_display_item.cc
@@ -13,7 +13,12 @@
namespace cc {
-FloatClipDisplayItem::FloatClipDisplayItem() {
+FloatClipDisplayItem::FloatClipDisplayItem(const gfx::RectF& clip_rect) {
+ SetNew(clip_rect);
+}
+
+FloatClipDisplayItem::FloatClipDisplayItem(const proto::DisplayItem& proto) {
+ FromProtobuf(proto);
}
FloatClipDisplayItem::~FloatClipDisplayItem() {
@@ -21,9 +26,6 @@ FloatClipDisplayItem::~FloatClipDisplayItem() {
void FloatClipDisplayItem::SetNew(const gfx::RectF& clip_rect) {
clip_rect_ = clip_rect;
-
- DisplayItem::SetNew(true /* suitable_for_gpu_raster */, 1 /* op_count */,
- 0 /* external_memory_usage */);
}
void FloatClipDisplayItem::ToProtobuf(proto::DisplayItem* proto) const {
@@ -57,9 +59,15 @@ void FloatClipDisplayItem::AsValueInto(
clip_rect_.ToString().c_str(), visual_rect.ToString().c_str()));
}
-EndFloatClipDisplayItem::EndFloatClipDisplayItem() {
- DisplayItem::SetNew(true /* suitable_for_gpu_raster */, 0 /* op_count */,
- 0 /* external_memory_usage */);
+size_t FloatClipDisplayItem::ExternalMemoryUsage() const {
+ return 0;
+}
+
+EndFloatClipDisplayItem::EndFloatClipDisplayItem() {}
+
+EndFloatClipDisplayItem::EndFloatClipDisplayItem(
+ const proto::DisplayItem& proto) {
+ FromProtobuf(proto);
}
EndFloatClipDisplayItem::~EndFloatClipDisplayItem() {
@@ -88,4 +96,8 @@ void EndFloatClipDisplayItem::AsValueInto(
visual_rect.ToString().c_str()));
}
+size_t EndFloatClipDisplayItem::ExternalMemoryUsage() const {
+ return 0;
+}
+
} // namespace cc

Powered by Google App Engine
This is Rietveld 408576698