Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1071)

Unified Diff: cc/playback/compositing_display_item.cc

Issue 1494223003: cc: Shrink size of display item (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make ui compile too oops Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/playback/compositing_display_item.cc
diff --git a/cc/playback/compositing_display_item.cc b/cc/playback/compositing_display_item.cc
index 667371bafe6674db3b8d677417be8150838d5c3e..f0c54a1511b1e05f8995b3c87da480dcd5655b41 100644
--- a/cc/playback/compositing_display_item.cc
+++ b/cc/playback/compositing_display_item.cc
@@ -19,7 +19,16 @@
namespace cc {
-CompositingDisplayItem::CompositingDisplayItem() {
+CompositingDisplayItem::CompositingDisplayItem(uint8_t alpha,
+ SkXfermode::Mode xfermode,
+ SkRect* bounds,
+ skia::RefPtr<SkColorFilter> cf) {
+ SetNew(alpha, xfermode, bounds, cf);
+}
+
+CompositingDisplayItem::CompositingDisplayItem(
+ const proto::DisplayItem& proto) {
+ FromProtobuf(proto);
}
CompositingDisplayItem::~CompositingDisplayItem() {
@@ -35,11 +44,6 @@ void CompositingDisplayItem::SetNew(uint8_t alpha,
if (bounds)
bounds_ = SkRect(*bounds);
color_filter_ = cf;
-
- // TODO(pdr): Include color_filter's memory here.
- size_t external_memory_usage = 0;
- DisplayItem::SetNew(true /* suitable_for_gpu_raster */, 1 /* op_count */,
- external_memory_usage);
}
void CompositingDisplayItem::ToProtobuf(proto::DisplayItem* proto) const {
@@ -106,9 +110,20 @@ void CompositingDisplayItem::AsValueInto(
static_cast<float>(bounds_.height())));
}
-EndCompositingDisplayItem::EndCompositingDisplayItem() {
- DisplayItem::SetNew(true /* suitable_for_gpu_raster */, 0 /* op_count */,
- 0 /* external_memory_usage */);
+size_t CompositingDisplayItem::ExternalMemoryUsage() const {
+ // TODO(pdr): Include color_filter's memory here.
+ return 0;
+}
+
+int CompositingDisplayItem::ApproximateOpCount() const {
+ return 1;
+}
+
+EndCompositingDisplayItem::EndCompositingDisplayItem() {}
+
+EndCompositingDisplayItem::EndCompositingDisplayItem(
+ const proto::DisplayItem& proto) {
+ FromProtobuf(proto);
}
EndCompositingDisplayItem::~EndCompositingDisplayItem() {
@@ -137,4 +152,12 @@ void EndCompositingDisplayItem::AsValueInto(
visual_rect.ToString().c_str()));
}
+size_t EndCompositingDisplayItem::ExternalMemoryUsage() const {
+ return 0;
+}
+
+int EndCompositingDisplayItem::ApproximateOpCount() const {
+ return 0;
+}
+
} // namespace cc

Powered by Google App Engine
This is Rietveld 408576698