Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Side by Side Diff: cc/playback/filter_display_item.h

Issue 1494223003: cc: Shrink size of display item (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make SetNew private Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CC_PLAYBACK_FILTER_DISPLAY_ITEM_H_ 5 #ifndef CC_PLAYBACK_FILTER_DISPLAY_ITEM_H_
6 #define CC_PLAYBACK_FILTER_DISPLAY_ITEM_H_ 6 #define CC_PLAYBACK_FILTER_DISPLAY_ITEM_H_
7 7
8 #include "base/memory/scoped_ptr.h" 8 #include "base/memory/scoped_ptr.h"
9 #include "cc/base/cc_export.h" 9 #include "cc/base/cc_export.h"
10 #include "cc/output/filter_operations.h" 10 #include "cc/output/filter_operations.h"
11 #include "cc/playback/display_item.h" 11 #include "cc/playback/display_item.h"
12 #include "ui/gfx/geometry/rect_f.h" 12 #include "ui/gfx/geometry/rect_f.h"
13 13
14 class SkCanvas; 14 class SkCanvas;
15 15
16 namespace cc { 16 namespace cc {
17 17
18 class CC_EXPORT FilterDisplayItem : public DisplayItem { 18 class CC_EXPORT FilterDisplayItem : public DisplayItem {
19 public: 19 public:
20 FilterDisplayItem(); 20 FilterDisplayItem(const FilterOperations& filters, const gfx::RectF& bounds);
21 explicit FilterDisplayItem(const proto::DisplayItem& proto);
21 ~FilterDisplayItem() override; 22 ~FilterDisplayItem() override;
22 23
23 void SetNew(const FilterOperations& filters, const gfx::RectF& bounds);
24
25 void ToProtobuf(proto::DisplayItem* proto) const override; 24 void ToProtobuf(proto::DisplayItem* proto) const override;
26 void FromProtobuf(const proto::DisplayItem& proto) override; 25 void FromProtobuf(const proto::DisplayItem& proto) override;
27 void Raster(SkCanvas* canvas, 26 void Raster(SkCanvas* canvas,
28 const gfx::Rect& canvas_target_playback_rect, 27 const gfx::Rect& canvas_target_playback_rect,
29 SkPicture::AbortCallback* callback) const override; 28 SkPicture::AbortCallback* callback) const override;
30 void AsValueInto(const gfx::Rect& visual_rect, 29 void AsValueInto(const gfx::Rect& visual_rect,
31 base::trace_event::TracedValue* array) const override; 30 base::trace_event::TracedValue* array) const override;
31 size_t ExternalMemoryUsage() const override;
32
33 int ApproximateOpCount() const { return 1; }
34 bool IsSuitableForGpuRasterization() const { return true; }
32 35
33 private: 36 private:
37 void SetNew(const FilterOperations& filters, const gfx::RectF& bounds);
38
34 FilterOperations filters_; 39 FilterOperations filters_;
35 gfx::RectF bounds_; 40 gfx::RectF bounds_;
36 }; 41 };
37 42
38 class CC_EXPORT EndFilterDisplayItem : public DisplayItem { 43 class CC_EXPORT EndFilterDisplayItem : public DisplayItem {
39 public: 44 public:
40 EndFilterDisplayItem(); 45 EndFilterDisplayItem();
46 explicit EndFilterDisplayItem(const proto::DisplayItem& proto);
41 ~EndFilterDisplayItem() override; 47 ~EndFilterDisplayItem() override;
42 48
43 static scoped_ptr<EndFilterDisplayItem> Create() { 49 static scoped_ptr<EndFilterDisplayItem> Create() {
44 return make_scoped_ptr(new EndFilterDisplayItem()); 50 return make_scoped_ptr(new EndFilterDisplayItem());
45 } 51 }
46 52
47 void ToProtobuf(proto::DisplayItem* proto) const override; 53 void ToProtobuf(proto::DisplayItem* proto) const override;
48 void FromProtobuf(const proto::DisplayItem& proto) override; 54 void FromProtobuf(const proto::DisplayItem& proto) override;
49 void Raster(SkCanvas* canvas, 55 void Raster(SkCanvas* canvas,
50 const gfx::Rect& canvas_target_playback_rect, 56 const gfx::Rect& canvas_target_playback_rect,
51 SkPicture::AbortCallback* callback) const override; 57 SkPicture::AbortCallback* callback) const override;
52 void AsValueInto(const gfx::Rect& visual_rect, 58 void AsValueInto(const gfx::Rect& visual_rect,
53 base::trace_event::TracedValue* array) const override; 59 base::trace_event::TracedValue* array) const override;
60 size_t ExternalMemoryUsage() const override;
61
62 int ApproximateOpCount() const { return 0; }
63 bool IsSuitableForGpuRasterization() const { return true; }
54 }; 64 };
55 65
56 } // namespace cc 66 } // namespace cc
57 67
58 #endif // CC_PLAYBACK_FILTER_DISPLAY_ITEM_H_ 68 #endif // CC_PLAYBACK_FILTER_DISPLAY_ITEM_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698