cc: Shrink size of display item

cc/playback/compositing_display_item.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/playback/compositing_display_item.h"
 
 #include "base/strings/stringprintf.h"
 #include "base/trace_event/trace_event_argument.h"
 #include "cc/proto/display_item.pb.h"
 #include "cc/proto/gfx_conversions.h"
 #include "cc/proto/skia_conversions.h"
 #include "third_party/skia/include/core/SkCanvas.h"
 #include "third_party/skia/include/core/SkData.h"
 #include "third_party/skia/include/core/SkFlattenable.h"
 #include "third_party/skia/include/core/SkFlattenableSerialization.h"
 #include "third_party/skia/include/core/SkPaint.h"
 #include "third_party/skia/include/core/SkXfermode.h"
 #include "ui/gfx/skia_util.h"
 
 namespace cc {
 
-CompositingDisplayItem::CompositingDisplayItem() {
+CompositingDisplayItem::CompositingDisplayItem(uint8_t alpha,
+                                               SkXfermode::Mode xfermode,
+                                               SkRect* bounds,
+                                               skia::RefPtr<SkColorFilter> cf) {
+  SetNew(alpha, xfermode, bounds, cf);

[danakj, 2015/12/08 19:18:14]

move cf

+}
+
+CompositingDisplayItem::CompositingDisplayItem(
+    const proto::DisplayItem& proto) {
+  FromProtobuf(proto);
 }
 
 CompositingDisplayItem::~CompositingDisplayItem() {
 }
 
 void CompositingDisplayItem::SetNew(uint8_t alpha,
                                     SkXfermode::Mode xfermode,
                                     SkRect* bounds,
                                     skia::RefPtr<SkColorFilter> cf) {
   alpha_ = alpha;
   xfermode_ = xfermode;
   has_bounds_ = !!bounds;
   if (bounds)
     bounds_ = SkRect(*bounds);
   color_filter_ = cf;

[danakj, 2015/12/08 19:18:14]

this should move cf too while you're at it

-
-  // TODO(pdr): Include color_filter's memory here.
-  size_t external_memory_usage = 0;
-  DisplayItem::SetNew(true /* suitable_for_gpu_raster */, 1 /* op_count */,
-                      external_memory_usage);
 }
 
 void CompositingDisplayItem::ToProtobuf(proto::DisplayItem* proto) const {
   proto->set_type(proto::DisplayItem::Type_Compositing);
 
   proto::CompositingDisplayItem* details = proto->mutable_compositing_item();
   details->set_alpha(static_cast<uint32_t>(alpha_));
   details->set_mode(SkXfermodeModeToProto(xfermode_));
   if (has_bounds_)
     RectFToProto(gfx::SkRectToRectF(bounds_), details->mutable_bounds());
@@ skipping 46 matching lines @@
   array->AppendString(base::StringPrintf(
       "CompositingDisplayItem alpha: %d, xfermode: %d, visualRect: [%s]",
       alpha_, xfermode_, visual_rect.ToString().c_str()));
   if (has_bounds_)
     array->AppendString(base::StringPrintf(
         ", bounds: [%f, %f, %f, %f]", static_cast<float>(bounds_.x()),
         static_cast<float>(bounds_.y()), static_cast<float>(bounds_.width()),
         static_cast<float>(bounds_.height())));
 }
 
-EndCompositingDisplayItem::EndCompositingDisplayItem() {
-  DisplayItem::SetNew(true /* suitable_for_gpu_raster */, 0 /* op_count */,
-                      0 /* external_memory_usage */);
+size_t CompositingDisplayItem::ExternalMemoryUsage() const {
+  // TODO(pdr): Include color_filter's memory here.
+  return 0;
+}
+
+EndCompositingDisplayItem::EndCompositingDisplayItem() {}
+
+EndCompositingDisplayItem::EndCompositingDisplayItem(
+    const proto::DisplayItem& proto) {
+  FromProtobuf(proto);
 }
 
 EndCompositingDisplayItem::~EndCompositingDisplayItem() {
 }
 
 void EndCompositingDisplayItem::ToProtobuf(proto::DisplayItem* proto) const {
   proto->set_type(proto::DisplayItem::Type_EndCompositing);
 }
 
 void EndCompositingDisplayItem::FromProtobuf(const proto::DisplayItem& proto) {
   DCHECK_EQ(proto::DisplayItem::Type_EndCompositing, proto.type());
 }
 
 void EndCompositingDisplayItem::Raster(
     SkCanvas* canvas,
     const gfx::Rect& canvas_target_playback_rect,
     SkPicture::AbortCallback* callback) const {
   canvas->restore();
 }
 
 void EndCompositingDisplayItem::AsValueInto(
     const gfx::Rect& visual_rect,
     base::trace_event::TracedValue* array) const {
   array->AppendString(
       base::StringPrintf("EndCompositingDisplayItem visualRect: [%s]",
                          visual_rect.ToString().c_str()));
 }
 
+size_t EndCompositingDisplayItem::ExternalMemoryUsage() const {
+  return 0;
+}
+
 }  // namespace cc