Add API to allow you to get the non-transactional datastore or taskqueue.

impl/memory/context.go

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package memory
 
 import (
         "errors"
         "sync"
 
         ds "github.com/luci/gae/service/datastore"
         "golang.org/x/net/context"
 )
 
 var serializationDeterministic = false
 
 type memContextObj interface {
         sync.Locker
         canApplyTxn(m memContextObj) bool
         applyTxn(c context.Context, m memContextObj)
 
         endTxn()
         mkTxn(*ds.TransactionOptions) memContextObj
 }
 
 type memContext []memContextObj
 
-var _ = memContextObj((memContext)(nil))
+var _ memContextObj = (*memContext)(nil)

[iannucci, 2015/12/04 03:35:10]

changed to a pointer to be == comparable

 
-func newMemContext(aid string) memContext {
-        return memContext{
+func newMemContext(aid string) *memContext {
+        return &memContext{
                 newTaskQueueData(),
                 newDataStoreData(aid),
         }
 }
 
 type memContextIdx int
 
 const (
         memContextTQIdx memContextIdx = iota
         memContextDSIdx
 )
 
-func (m memContext) Get(itm memContextIdx) memContextObj {
-        return m[itm]
+func (m *memContext) Get(itm memContextIdx) memContextObj {
+        return (*m)[itm]
 }
 
-func (m memContext) Lock() {
-        for _, itm := range m {
+func (m *memContext) Lock() {
+        for _, itm := range *m {
                 itm.Lock()
         }
 }
 
-func (m memContext) Unlock() {
-        for i := len(m) - 1; i >= 0; i-- {
-                m[i].Unlock()
+func (m *memContext) Unlock() {
+        for i := len(*m) - 1; i >= 0; i-- {
+                (*m)[i].Unlock()
         }
 }
 
-func (m memContext) endTxn() {
-        for _, itm := range m {
+func (m *memContext) endTxn() {
+        for _, itm := range *m {
                 itm.endTxn()
         }
 }
 
-func (m memContext) mkTxn(o *ds.TransactionOptions) memContextObj {
-        ret := make(memContext, len(m))
-        for i, itm := range m {
+func (m *memContext) mkTxn(o *ds.TransactionOptions) memContextObj {
+        ret := make(memContext, len(*m))
+        for i, itm := range *m {
                 ret[i] = itm.mkTxn(o)
         }
-        return ret
+        return &ret
 }
 
-func (m memContext) canApplyTxn(txnCtxObj memContextObj) bool {
-        txnCtx := txnCtxObj.(memContext)
-        for i := range m {
-                if !m[i].canApplyTxn(txnCtx[i]) {
+func (m *memContext) canApplyTxn(txnCtxObj memContextObj) bool {
+        txnCtx := *txnCtxObj.(*memContext)
+        for i := range *m {
+                if !(*m)[i].canApplyTxn(txnCtx[i]) {
                         return false
                 }
         }
         return true
 }
 
-func (m memContext) applyTxn(c context.Context, txnCtxObj memContextObj) {
-        txnCtx := txnCtxObj.(memContext)
-        for i := range m {
-                m[i].applyTxn(c, txnCtx[i])
+func (m *memContext) applyTxn(c context.Context, txnCtxObj memContextObj) {
+        txnCtx := *txnCtxObj.(*memContext)
+        for i := range *m {
+                (*m)[i].applyTxn(c, txnCtx[i])
         }
 }
 
 // Use calls UseWithAppID with the appid of "dev~app"
 func Use(c context.Context) context.Context {
         return UseWithAppID(c, "dev~app")
 }
 
 // UseWithAppID adds implementations for the following gae interfaces to the
 // context:
 //   * gae.Datastore
 //   * gae.TaskQueue
 //   * gae.Memcache
 //   * gae.GlobalInfo
 //
 // The application id wil be set to 'aid', and will not be modifiable in this
 // context.
 //
 // These can be retrieved with the gae.Get functions.
 //
 // The implementations are all backed by an in-memory implementation, and start
 // with an empty state.
 //
 // Using this more than once per context.Context will cause a panic.
 func UseWithAppID(c context.Context, aid string) context.Context {
         if c.Value(memContextKey) != nil {
                 panic(errors.New("memory.Use: called twice on the same Context"))
         }
-        c = context.WithValue(
-                context.WithValue(c, memContextKey, newMemContext(aid)),
-                giContextKey, &globalInfoData{appid: aid})
+        memctx := newMemContext(aid)
+        c = context.WithValue(c, memContextKey, memctx)
+        c = context.WithValue(c, memContextNoTxnKey, memctx)
+        c = context.WithValue(c, giContextKey, &globalInfoData{appid: aid})
+
         return useTQ(useRDS(useMC(useGI(c, aid))))
 }
 
-func cur(c context.Context) (p memContext) {
-        p, _ = c.Value(memContextKey).(memContext)
+func cur(c context.Context) (p *memContext) {
+        p, _ = c.Value(memContextKey).(*memContext)
+        return
+}
+
+func curNoTxn(c context.Context) (p *memContext) {
+        p, _ = c.Value(memContextNoTxnKey).(*memContext)
         return
 }
 
 type memContextKeyType int
 
-var memContextKey memContextKeyType
+var (
+        memContextKey      memContextKeyType
+        memContextNoTxnKey memContextKeyType = 1
+)
 
 // weird stuff
 
 // RunInTransaction is here because it's really a service-wide transaction, not
 // just in the datastore. TaskQueue behaves differently in a transaction in
 // a couple ways, for example.
 //
 // It really should have been appengine.Context.RunInTransaction(func(tc...)),
 // but because it's not, this method is on dsImpl instead to mirror the official
 // API.
@@ skipping 40 matching lines @@
         if o != nil && o.Attempts != 0 {
                 attempts = o.Attempts
         }
         for attempt := 0; attempt < attempts; attempt++ {
                 if err := loopBody(attempt >= d.data.txnFakeRetry); err != ds.ErrConcurrentTransaction {
                         return err
                 }
         }
         return ds.ErrConcurrentTransaction
 }