Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 149416: Properly restart extensions with no visible UI. (Closed)

Created:
11 years, 5 months ago by Paweł Hajdan Jr.
Modified:
9 years, 7 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews_googlegroups.com, Erik does not do reviews, Ben Goodger (Google)
Visibility:
Public.

Description

Properly restart extensions with no visible UI. http://crbug.com/16070 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20376

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M chrome/browser/extensions/extension_host.cc View 1 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Paweł Hajdan Jr.
I'm not sure what is the best way to handle the case when #ifdef TOOLKIT_VIEWS ...
11 years, 5 months ago (2009-07-09 21:29:19 UTC) #1
Matt Perry
http://codereview.chromium.org/149416/diff/1/2 File chrome/browser/extensions/extension_host.cc (right): http://codereview.chromium.org/149416/diff/1/2#newcode141 Line 141: render_view_host_->CreateRenderView(); I think you want to call CreateRenderView(NULL) ...
11 years, 5 months ago (2009-07-09 21:38:15 UTC) #2
Paweł Hajdan Jr.
Done.
11 years, 5 months ago (2009-07-09 22:02:46 UTC) #3
Matt Perry
11 years, 5 months ago (2009-07-09 22:06:12 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698