Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2099)

Unified Diff: chrome/browser/ui/webui/signin/user_manager_screen_handler.h

Issue 1494153002: This CL replaces e-mail with AccountId in easy signin code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update after review. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/signin/user_manager_screen_handler.h
diff --git a/chrome/browser/ui/webui/signin/user_manager_screen_handler.h b/chrome/browser/ui/webui/signin/user_manager_screen_handler.h
index 9d87349703e6fb4541d5494a96a503252b336f83..57296e8ac2d37cd0bc8358177646156205746247 100644
--- a/chrome/browser/ui/webui/signin/user_manager_screen_handler.h
+++ b/chrome/browser/ui/webui/signin/user_manager_screen_handler.h
@@ -23,6 +23,7 @@
#include "content/public/browser/web_ui_message_handler.h"
#include "google_apis/gaia/gaia_oauth_client.h"
+class AccountId;
class GaiaAuthFetcher;
namespace base {
@@ -40,11 +41,12 @@ class UserManagerScreenHandler
UserManagerScreenHandler();
~UserManagerScreenHandler() override;
+ void GetLocalizedValues(base::DictionaryValue* localized_strings);
+
+ private:
// WebUIMessageHandler implementation.
void RegisterMessages() override;
- void GetLocalizedValues(base::DictionaryValue* localized_strings);
-
// content::NotificationObserver implementation:
void Observe(int type,
const content::NotificationSource& source,
@@ -53,23 +55,22 @@ class UserManagerScreenHandler
// proximity_auth::ScreenlockBridge::LockHandler implementation.
void ShowBannerMessage(const base::string16& message) override;
void ShowUserPodCustomIcon(
- const std::string& user_email,
+ const AccountId& account_id,
const proximity_auth::ScreenlockBridge::UserPodCustomIconOptions&
icon_options) override;
- void HideUserPodCustomIcon(const std::string& user_email) override;
+ void HideUserPodCustomIcon(const AccountId& account_id) override;
void EnableInput() override;
void SetAuthType(
- const std::string& user_email,
+ const AccountId& account_id,
proximity_auth::ScreenlockBridge::LockHandler::AuthType auth_type,
const base::string16& auth_value) override;
- AuthType GetAuthType(const std::string& user_email) const override;
+ AuthType GetAuthType(const AccountId& account_id) const override;
ScreenType GetScreenType() const override;
- void Unlock(const std::string& user_email) override;
- void AttemptEasySignin(const std::string& user_email,
+ void Unlock(const AccountId& account_id) override;
+ void AttemptEasySignin(const AccountId& account_id,
const std::string& secret,
const std::string& key_label) override;
- private:
// An observer for any changes to Profiles in the ProfileInfoCache so that
// all the visible user manager screens can be updated.
class ProfileUpdateObserver;
achuithb 2015/12/04 20:23:39 Let's move this and the comment to right after pri
Alexander Alekseev 2015/12/05 05:20:07 Done.

Powered by Google App Engine
This is Rietveld 408576698