Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6209)

Unified Diff: chrome/browser/chromeos/login/user_flow.cc

Issue 1494153002: This CL replaces e-mail with AccountId in easy signin code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix build. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/user_flow.cc
diff --git a/chrome/browser/chromeos/login/user_flow.cc b/chrome/browser/chromeos/login/user_flow.cc
index 74e37c34cd7a55bb115c242a19c0de04c514c6b8..5e8f233b4a9670b0f766585e8ce57def7e764394 100644
--- a/chrome/browser/chromeos/login/user_flow.cc
+++ b/chrome/browser/chromeos/login/user_flow.cc
@@ -12,8 +12,8 @@ namespace chromeos {
namespace {
-void UnregisterFlow(const std::string& user_id) {
- ChromeUserManager::Get()->ResetUserFlow(AccountId::FromUserEmail(user_id));
+void UnregisterFlow(const AccountId& account_id) {
achuithb 2015/12/04 10:12:52 This function seems unnecessary?
Alexander Alekseev 2015/12/04 12:44:06 This is used in ExtendedUserFlow::UnregisterFlowSo
achuithb 2015/12/04 20:16:56 No, I meant that in UnregisterFlowSoon, you could
Alexander Alekseev 2015/12/05 05:20:07 Done.
+ ChromeUserManager::Get()->ResetUserFlow(account_id);
}
} // namespace
@@ -70,9 +70,8 @@ void DefaultUserFlow::HandleOAuthTokenStatusChange(
void DefaultUserFlow::LaunchExtraSteps(Profile* profile) {
}
-ExtendedUserFlow::ExtendedUserFlow(const std::string& user_id)
- : user_id_(user_id) {
-}
+ExtendedUserFlow::ExtendedUserFlow(const AccountId& account_id)
+ : account_id_(account_id) {}
ExtendedUserFlow::~ExtendedUserFlow() {
}
@@ -89,10 +88,8 @@ void ExtendedUserFlow::HandleOAuthTokenStatusChange(
}
void ExtendedUserFlow::UnregisterFlowSoon() {
- std::string id_copy(user_id());
- base::MessageLoop::current()->PostTask(FROM_HERE,
- base::Bind(&UnregisterFlow,
- id_copy));
+ base::MessageLoop::current()->PostTask(
+ FROM_HERE, base::Bind(&UnregisterFlow, account_id()));
}
} // namespace chromeos

Powered by Google App Engine
This is Rietveld 408576698