chrome/browser/chromeos/login/supervised/supervised_user_creation_controller_new.h - Issue 1494153002: This CL replaces e-mail with AccountId in easy signin code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/supervised/supervised_user_creation_controller_new.h

Issue 1494153002: This CL replaces e-mail with AccountId in easy signin code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix build. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager.cc ('K') | « chrome/browser/chromeos/login/session/user_session_manager.cc ('k') | chrome/browser/chromeos/login/supervised/supervised_user_creation_controller_new.cc » ('j') | chrome/browser/chromeos/login/supervised/supervised_user_login_flow.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/supervised/supervised_user_creation_controller_new.h

diff --git a/chrome/browser/chromeos/login/supervised/supervised_user_creation_controller_new.h b/chrome/browser/chromeos/login/supervised/supervised_user_creation_controller_new.h

index 597fab09ec13a87260854556ff9c4a115267c62e..b27210218928fa7e67886f7d0ae1af221102075c 100644

--- a/chrome/browser/chromeos/login/supervised/supervised_user_creation_controller_new.h

+++ b/chrome/browser/chromeos/login/supervised/supervised_user_creation_controller_new.h

@@ -16,6 +16,7 @@

#include "chrome/browser/chromeos/login/supervised/supervised_user_creation_controller.h"

#include "chrome/browser/supervised_user/legacy/supervised_user_registration_utility.h"

#include "chromeos/login/auth/extended_authenticator.h"

+#include "components/signin/core/account_id/account_id.h"

class Profile;

@@ -41,7 +42,7 @@ class SupervisedUserCreationControllerNew

// |Consumer| is not owned by controller, and it is expected that it wouldn't

// be deleted before SupervisedUserCreationControllerNew.

SupervisedUserCreationControllerNew(StatusConsumer* consumer,

- const std::string& manager_id);

+ const AccountId& manager_id);

~SupervisedUserCreationControllerNew() override;

// Returns the current supervised user controller if it has been created.

@@ -119,7 +120,7 @@ class SupervisedUserCreationControllerNew

base::string16 display_name;

int avatar_index;

- std::string manager_id;

+ AccountId manager_id = EmptyAccountId();

achuithb 2015/12/04 10:12:52 Why do this? the default ctor does the right thing

Alexander Alekseev 2015/12/04 12:44:06 We cannot make AccountId default-constructible unt

std::string local_user_id; // Used to identify cryptohome.

std::string sync_user_id; // Used to identify user in manager's sync data.