Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1243)

Unified Diff: chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc

Issue 1494153002: This CL replaces e-mail with AccountId in easy signin code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Bugfix in original easy unlock code' Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc
diff --git a/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc b/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc
index 5e03a09cf4395fd073a29acd8e555ba37ceab87f..08d0005951d2e40bf3ec8a6833c2e5f5edc9d738 100644
--- a/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc
+++ b/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc
@@ -42,6 +42,7 @@
#include "components/proximity_auth/screenlock_bridge.h"
#include "components/proximity_auth/screenlock_state.h"
#include "components/proximity_auth/switches.h"
+#include "components/signin/core/account_id/account_id.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/web_contents.h"
#include "extensions/browser/browser_context_keyed_api_factory.h"
@@ -841,7 +842,7 @@ bool EasyUnlockPrivateGetSignInChallengeFunction::RunAsync() {
return false;
}
key_manager->SignUsingTpmKey(
- EasyUnlockService::Get(profile)->GetUserEmail(),
+ EasyUnlockService::Get(profile)->GetAccountId(),
std::string(params->nonce.begin(), params->nonce.end()),
base::Bind(&EasyUnlockPrivateGetSignInChallengeFunction::OnDone, this,
challenge));
@@ -893,22 +894,22 @@ bool EasyUnlockPrivateGetUserInfoFunction::RunSync() {
EasyUnlockService* service =
EasyUnlockService::Get(Profile::FromBrowserContext(browser_context()));
std::vector<linked_ptr<easy_unlock_private::UserInfo> > users;
- std::string user_id = service->GetUserEmail();
- if (!user_id.empty()) {
+ const AccountId& account_id = service->GetAccountId();
+ if (account_id.is_valid()) {
users.push_back(
linked_ptr<easy_unlock_private::UserInfo>(
new easy_unlock_private::UserInfo()));
- users[0]->user_id = user_id;
+ users[0]->user_id = account_id.GetUserEmail();
users[0]->logged_in = service->GetType() == EasyUnlockService::TYPE_REGULAR;
users[0]->data_ready = users[0]->logged_in ||
service->GetRemoteDevices() != NULL;
EasyUnlockService::UserSettings user_settings =
- EasyUnlockService::GetUserSettings(user_id);
+ EasyUnlockService::GetUserSettings(account_id);
users[0]->require_close_proximity = user_settings.require_close_proximity;
users[0]->device_user_id = proximity_auth::CalculateDeviceUserId(
- EasyUnlockService::GetDeviceId(), user_id);
+ EasyUnlockService::GetDeviceId(), account_id.GetUserEmail());
users[0]->ble_discovery_enabled =
base::CommandLine::ForCurrentProcess()->HasSwitch(

Powered by Google App Engine
This is Rietveld 408576698