Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Unified Diff: chrome/browser/chromeos/login/existing_user_controller.cc

Issue 1494153002: This CL replaces e-mail with AccountId in easy signin code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Bugfix in original easy unlock code' Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/existing_user_controller.cc
diff --git a/chrome/browser/chromeos/login/existing_user_controller.cc b/chrome/browser/chromeos/login/existing_user_controller.cc
index 94c54babd9e8a57d34cadacedfb6a922e7f89b6e..8655f71b6af7e6c6fc1c7ee68bceb5dbc03d170c 100644
--- a/chrome/browser/chromeos/login/existing_user_controller.cc
+++ b/chrome/browser/chromeos/login/existing_user_controller.cc
@@ -125,8 +125,7 @@ void RecordPasswordLoginEvent(const UserContext& user_context) {
if (user_context.GetUserType() == user_manager::USER_TYPE_REGULAR &&
user_context.GetAuthFlow() == UserContext::AUTH_FLOW_OFFLINE &&
easy_unlock_service) {
- easy_unlock_service->RecordPasswordLoginEvent(
- user_context.GetAccountId().GetUserEmail());
+ easy_unlock_service->RecordPasswordLoginEvent(user_context.GetAccountId());
}
}
@@ -438,12 +437,13 @@ void ExistingUserController::Signout() {
NOTREACHED();
}
-bool ExistingUserController::IsUserWhitelisted(const std::string& user_id) {
+bool ExistingUserController::IsUserWhitelisted(const AccountId& account_id) {
bool wildcard_match = false;
if (login_performer_.get())
- return login_performer_->IsUserWhitelisted(user_id, &wildcard_match);
+ return login_performer_->IsUserWhitelisted(account_id, &wildcard_match);
- return chromeos::CrosSettings::IsWhitelisted(user_id, &wildcard_match);
+ return chromeos::CrosSettings::IsWhitelisted(account_id.GetUserEmail(),
+ &wildcard_match);
}
void ExistingUserController::OnConsumerKioskAutoLaunchCheckCompleted(

Powered by Google App Engine
This is Rietveld 408576698